Re: [SM-DEVEL] show thumbnails...

[javier w. <jav...@gm...>]

On 9/17/07, Tomas Kuliavas <to...@us...> wrote:
> >> close imap connection in download_thumb.php and remove conditions from
> >> init function.
> >
> >ok, i close the connection now, but i didn't understand "remove
> >conditions from init function." there's no init in 1.4.x, is there? if
> >i remove the condition (if file_exists) it could lead to a warning.
>
> squirrelmail_plugin_init_show_thumb() function. I think your $thumb_type
> configuration settings are ignored in 1.5.2-svn. SquirrelMail 1.5.2-svn
> won't call squirrelmail_plugin_init_show_thumb() function.
>
> it is strongly recommended not to execute anything in plugin init function.
> Just set hooks and handle hook differences later. In 1.5.1 and older you can
> get hook name from $Args[0] in show_thumb_do(). Not sure about 1.5.2-svn. Or
> hookup different functions to 'attachment $type0/type1' hooks and check
> $thumb_type in those functions.

done.

i took your advice into account and made many changes, i checked it
works in 1.4.10, 1.5.1 and 1.5.2svn. i don't use 'extra' anymore,
changed the plugin_init and also the included files in download_thumb.

javier