Re: [SM-DEVEL] [SM-CVS] SF.net SVN: squirrelmail: [12531] trunk/squirrelmail/src

[Antoine Delignat-L. <an...@de...>]

Paul Lesniewski wrote:
> On 7/14/07, Antoine Delignat-Lavaud <an...@de...> wrote:
>   
>> Paul Lesniewski wrote:
>>     
>>>>>> rename squirrelmail_rpc.php to rpc.php, it doesn't make much sense to
>>>>>> have 'squirrelmail' in our path components (i.e. also no
>>>>>> squirrelmail_compose.php)
>>>>>>
>>>>>>             
>>>>> There was thinking behind this choice.  This page has a much different
>>>>> significance than the compose page.  The decision was made to include
>>>>> "squirrelmail" in the name because of how the page could be accessed.
>>>>> If someone is using it for some web service request that is *outside*
>>>>> of the SM envronment - in another application, the page name makes it
>>>>> more clear and gives us some well-deserved advertising...  I suppose
>>>>> it's OK to rename it (although would have liked to discuss first).
>>>>>
>>>>>           
>>>> Ah, I thought it was 'just' a mistake which I fixed right away. Feel free to
>>>> move it back.
>>>>
>>>>         
>> It is indeed more obvious to have squirrelmail in the name if the file
>> is included from an external source, but I don't think this matters all
>> in all, since in a typical case, the file will be included using
>> something like <require "path/squirrelmail/src/rpc.php">, which is
>> obvious enough.
>>     
>
> It's an *RPC* interface.  The file is accessed via HTTP - we're
> talking about the way it is accessed from external environments, not
> about its use internal to SM with include()/require().
>
> Cheers,
> Paul
>   
My mistake. squirrelmail_rpc is indeed better for that purpose, 
especially if for some reason SquirrelMail's folder name was changed to 
a less obvious name (such as wm, webmail, mail...)

Antoine