[SM-DEVEL] Tools Page: A "duplicate" of the Options Page for... Tools!

[Alexandros V. <av...@no...>]

With the minor changes that the attached patch of src/options.php
shows, the Options page can easily be reproduced to display a different
set of links.

Why?

* Many things under "Options" are not ... options! Examples: Change
Password, links to Directory services, IMAP server information, Address
Book Import/Export, Shared Folders information, POP3 Fetch (the
actual fetch page, not the options page).

* If the above were to be transferred to a new "Tools" page, then it
would remove the huge clutter from the Options page.

* Also, if the above were to be transferred to a new "Tools" page, then
plugin authors wouldn't be tempted to clutter the top header links with
a link to their application, but would instead use the Tools page
facilities.

* The infrastructure of the Options page is already very nice, and it's
good to have the same $optpage stuff for tools links, unlike previous
attempts (such as Erin's utilities plugin).

* Only one additional optpage variable. I called it 'profile'. So
'profile' => 'tools'  = the link goes under the tools page. Backward
compatibility, too: undefined = 'options'.

* Easy to fix existing plugins. Add the 'profile' argument, and after
submitting return to the options.php?profile=tools page.

* Easy to expand to a third set of links. (I can't think of one right
now).

* Should follow the same "options" template, if applied to 1.5.


Comments? Would you agree on this being committed to 1.5?


P.S. I've also added the link myself to page_header.php:

    displayInternalLink ('src/options.php', _("Options"));
    echo "  \n";
    displayInternalLink ('src/options.php?profile=tools', _("Tools"));
    echo "  \n";



-- 
Alexandros Vellis
National & Kapodistrian University of Athens
Network Operations Centre