Re: [SM-DEVEL] mem usage patch for stable related to forward

[Thijs K. <ki...@sq...>]

On Mon, 2007-01-22 at 17:48 +0100, Marc Groot Koerkamp wrote:
> Also included a fix for the getFilename method in the messages class. It
> looks like it works on stable. I just copied the function from devel and
> the messages class doesn't differ much so it can probably applied as well.

Please apply.

I've got one comment:

-            fputs($fp, decodeBody(mime_fetch_body($imapConnection,
-                            $passed_id, $message->entity_id),
-                        $message->header->encoding));
+            mime_print_body_lines ($imapConnection, $passed_id,
$message->entity_id, $message->header->encoding, $fp);
             fclose ($fp);
+//            fputs($fp, decodeBody(mime_fetch_body($imapConnection,
+//                            $passed_id, $message->entity_id),
+//                        $message->header->encoding));
+//            fclose ($fp);

Please don't comment out code like that. If someone passes over that
code a couple of months from now, he will see some commented out
lines... but why?

If the code is not needed anymore, just delete it. It can easily be
reverted because we use a revision control system.

If there's a good reason to leave it commented out, add a comment why
that is.


Thijs