From: Alexandros V. <av...@no...> - 2006-11-06 18:56:12
|
On Mon, 6 Nov 2006 07:51:21 -0800 "Paul Lesniewski" <pa...@sq...> wrote: (snip) > > Anyone care to test on PHP4? > > > > .... ah wait, I am pretty sure PHP4 will complain, since I got this to > > work even when the args in my plugin are not passed by value. Thanks Paul for the replies. I *did* try using the existing hook in PHP4 and while it didn't complain, it just didn't work -- variable was left untouched. > When someone can test in PHP4 (yeah yeah I should get myself a test > environment...), the fix might be to simply change this line in > functions/plugin.php (line 152 in cvs HEAD): > > - function concat_hook_function($name,$parm=NULL) { > + function concat_hook_function($name,&$parm=NULL) { > > In which case we should think about changing ALL hook functions in the > same way unless there is a good reason not to. I vote yes on this, so that there are similar results between PHP4 & PHP5. Will test this shortly... Alexandros |