Re: [SM-PLUGINS] Message Filters Plugin Bug

[Tomas K. <to...@us...>]

>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hello Daniel Watts,
>> On Thursday, September 22, 2005, you wrote:
>>
>>> Bug(ish) Report:
>>
>>> SQM: 1.4.4a
>>> PHP: 4.3.11
>>> RHEL.
>>
>>> Summary: If you remove a destination folder and an email arrives login
>>> to the account is prevented.
>>
>> I believe this is fixed in CVS.  Or at least I think Tomas looked at
>> it a while back.  Or at least it might be in devel.  1.4.4a is a
>> version back so it might have sneaked into 1.4.5 or 1.4.6-cvs.  Want
>> to test a cvs snapshot for the stable branch?
>
> SquirrelMail 1.4.5 contains mail_fetch plugin fixes related to imap folder
> changes. Not filters plugin.
>
> sqimap_mailbox_exists() does not work as expected in filters plugin.
> Something causes "* NO Error in IMAP command received by server. "
> response and command returns true, when mailbox does not exist.

plugins/filters/filters.php

Find

$search_str .= ' ' . $where . ' {' . strlen($what) . "}\r\n"
                    . $what . "\r\n";

and replace it with

$search_str .= ' ' . $where . ' {' . strlen($what) . "}\r\n"
                    . $what;

Remove last \r\n. SquirrelMail adds it automatically. If extra \r\n is
added, it causes problems with next issued imap command. Filters plugin
issues search command with extra \r\n and then checks if mailbox exists.
Mailbox exist check gets error message from previous imap command.


-- 
Tomas