[SM-PLUGINS] Re: Filters Plugin - BADCHARSET

[PajaP <sou...@pa...>]

On Sun, 07 Aug 2005 00:35:41 +0100, Pajap
<sou...@pa...> wrote:

>Hi
>
>I have a problem with the filters plugin.
>There was a lot of messages to the lists about a similar problem
>previously but the 'fix' seems to have been implemented now.
>I am getting the following error when I try to create a simple filter
>to move a message to another folder, based on a header.
>
>------
>ERROR: Could not complete request.
>Query: SEARCH CHARSET US-ASCII ALL From {4} paul
>Reason Given: [BADCHARSET] Character set not supported.
>------
>

OK, I seem to have fixed this!
Now my php is pretty rubbish to say the least but I noticed an
inconsistency between filters.php and imap_search.php

In filters.php:
-------------
    if ($allow_charset_search &&
isset($languages[$squirrelmail_language]['CHARSET']) &&
        $languages[$squirrelmail_language]['CHARSET']) {
        $search_str = 'SEARCH CHARSET '
                    .
strtoupper($languages[$squirrelmail_language]['CHARSET'])
                    . ' ' . $category;
    } else {
        $search_str = 'SEARCH CHARSET US-ASCII ' . $category;
                              ^^^^^^^^^^^^^^^^   
-------------


In imap_search.php:
-------------
    if ($allow_charset_search &&
isset($languages[$squirrelmail_language]['CHARSET']) &&
        $languages[$squirrelmail_language]['CHARSET']) {
        $ss = "SEARCH CHARSET "
            .
strtoupper($languages[$squirrelmail_language]['CHARSET'])
            . " ALL $search_string";
    } else {
        $ss = "SEARCH ALL $search_string";
                     ^^^^^
-------------

All I have done is to replace, in filters.php, the line:
$search_str = 'SEARCH CHARSET US-ASCII ' . $category;

With the line:
$search_str = 'SEARCH All ' . $category;

Now this seems to be working. I am no longer getting any error
messages and filters appear to be working.

All I ask is if someone from the sm team could please look at this and
let me know if I have made a major boo-boo. For this I would be very
grateful. :o)

I am probably going to have a few more questions, sort of related to
this but not directly. Because of this I will put them in a new
thread.

-- 
Many thanks
PajaP