Re: [SM-PLUGINS] cross-browser autocomplete plugin (solved)

[Andy W. <aj...@ph...>]

On Wed, Apr 20, 2005 at 02:09:55PM -0600, javier wilson wrote:
> On 4/20/05, javier wilson <jav...@gm...> wrote:
> > 
> > I just read in the javascript code:
> > ---
> > //disable browser's own autocompletion
> >    if (input.setAttribute) input.setAttribute('autocomplete', 'off');
> > ---
> > this means that my browser should not autocomplete, right?
> > i wonder why this isn't working. in my javascript console i get:
> > 
> > ---
> > Error: document.getElementById("send_to").input has no properties
> > Source File: http://example.org/src/compose.php?mailbox=INBOX&startMessage=1
> > Line: 194
> > ---

I see I had a couple of bad lines in functions.php.  I was using 
document.getElementById(\'xxx\').input.selectMatchRemove

when it should be just
document.getElementById(\'xxx\').selectMatchRemove

> 
> i am sorry to send three emails in a row, but i was excited about this
> plugin. i solved the problem, i have tested it in IE 6 and Firefox (SM 1.5.1cvs)
> and works fine. i also modified it a little bit so that it can you use theme
> colors, that improves presentation. also, startingWith was being set to false
> by default.
> 
> here's the diff file for functions.php

Thanks for the improvements to use the theme colors.  startingWith
should probably be true.  I obviously screwed that up since I was
setting it to true and then setting it back to false, but the previous
errors with the selectMatchRemove masked those problems.  

You shouldn't comment this function:

var oldhandler = window.onload;
window.onload = function()
{
if (oldhandler)
  oldhandler();
newhandler();

}

It's a trick to keep the original onload function ( checkForm() ) and
still let the autocomplete work onload.  
I've checked and the browser autocomplete should really be off, now.

I've updated the tarball with these changes.