Re: [SM-DEVEL] 1.5.1[cvs] flags not working

[Jonathan A. <jo...@sq...>]

Hello Kim,
On Friday, October 29, 2004, Kim Culhan wrote...


>> On Fri, October 29, 2004 10:22, Tomas Kuliavas said:

>>> On Fri, October 29, 2004 10:39, Maurice Makaay said:

>>> Hi Kim,
>>> 
>>> 
>>>> Is the flags feature broken in the cvs tree at the moment?
>>>> 
>>>> 
>>>> If I mark a message and hit Flag it appears to have no effect.
>>>> 
>>>> 
>>>> Sorry for this newb sounding question but I'm new to debugging
>>>> squirrelmail problems.
>>> 
>>> So was I some time ago... I have posted a bug report for this,
>>> but apparently the CVS tree has not been fixed yet :-( To see what
> I did
>>> to fix the problem in a rather crude manner (but regaining
>>> functionality), please take a look at:
>>> 
>>> http://sourceforge.net/mailarchive/message.php?msg_id=8783222
>>> 
>> 
>> apache 1.3.26 (debian), php 4.3.8, register_global off,
> squirrelmail cvs 
>> about 2-3 week old. imap server - default debian courier-imap
> recompiled 
>> with --enable-unicode. server side sorting = on. thread sorting =
> on. 
>> default mailbox sorting order.
>> 
>> Flags are working.

> Hmm.. so the question would be: which factor broke flags ?

> -kim

It's fairly simple... Marc is in the process of rewriting how we
handle emails from an IMAP server IF you don't have server side sort
enabled. He is basically cutting it down to fetching only the required
parts to sort, and then the required emails to display. For example if
you sort by date, it does 2 fetch statements, one for the UID and the
DATE field... it then sorts that information, and then fetches just
the range that are required. Say you have 15 messages per page, and
are on page 2, it will select messages 16 though to 30, and fetch the
necessary headers. This is in a goal to reduce load on the mail
server, and load on the web server.

But as you all know, devel means it is likely to break, be broken,
have bugs, be constantly changing etc etc. As such, Marc probably
hasn't got to the stage of fixing the cached information with the
changes. The fix to force the mailbox cache to false every page load
will work, but negates the whole point of using the cache in the first
place. I'll take a look, if somebody hasn't already, to see what we
can do about fixing the cache correctly.

-- 
Jonathan Angliss
(jo...@sq...)

Posting Hints: http://www.squirrelmail.org/wiki/en_US/MailingListPostingGuidelines