Re: [SM-DEVEL] Re: [SM-CVS] CVS: squirrelmail/src right_main.php,1.104.2.5, 1.104.2.6

[Jonathan A. <jo...@sq...>]

Hello Thijs,
On Monday, August 16, 2004, Thijs Kinkhorst wrote...

> On Mon, August 16, 2004 6:19, Jonathan Angliss said:
>> +if (!isset($show_num) || empty($show_num) || ($show_num == 0)) {
>> +    setPref($data_dir, $username, 'show_num' , 15);
>> +    $show_num = 15;
>> +}
>> +

> This "15" really should be a constant defined in a central place
> rather than buried in the code in different places. Do we currently
> have a place to define constants (I think not?)?

Well in theory, this should be a default_pref thing, but I picked 15
for some reason, i thought it was what it was set to when it was not
set at all in the user options.  I could be wrong.

> I propose that we create a include/constants.php file which
> defines this kind of data, mostly fallback or default values
> (default wrap-lines-at or subject-trim-length are other examples).

I think it'd be useful for a central place for the constants.

-- 
Jonathan Angliss
(jo...@sq...)