Re: [SM-DEVEL] Bad or malformed request

[Marc G. K. <ma...@sq...>]

Harold Paulson said:
> Hey,
>
> Are you testing with UW-IMAP ? There is some indication that it might
> be IMAP server specific...
>
> I have a message that breaks SM on my UW server with, and only with
> thread view on.
>
> I moved the message that was breaking my IMAP-UW server over to my
> Courier server and it does NOT cause problems there, with thread view
> on or off.
>
> The message in question has several wrapped headers.  Received and
> Content-Type, which are quite commonly wrapped, and also In-Reply-To
> and References.  Here are those two lines:
>
> In-Reply-To: <653...@ma...erraweb.c=
o
>   m>
> References: <5.1...@ma...>
>   <140...@ma...
> <5.1...@ma...>
>

FYI: The wrong wrapped reference headers were caused by SquirrelMail.
Squirrelmail 1.4.1 contains a few fixes regarding wrapping of reference
headers.


> I would expect that both of those lines are involved in sorting out
> which emails belong to which threads.
>
> That will prolly wrap badly, so I will point out that "In-Reply-To"
> is wrapped after the "o" in sierraweb.com, and "References" is
> wrapped after each reference.  Note that the second reference seems
> to be missing a ">".  Dunno if that is significant.
>
> If I remove BOTH lines (one is not enough) then I can view a mailbox
> listing with this message, on UW, in thread view.  So my guess is
> that something changed in the thread-view code recently, that dies on
> significant wrapped headers from IMAP-UW servers.
>

SquirrelMail didn't change the threadview code.

What I did change was a modification when we retrieve all headers in a
mailbox (no pagination). Instead of providing a msgs_set string with all
the individual uid's and/or uid ranges we do provide 1:* as msgs_set. If
UID support is broken (older UW servers) then it can cause the BAD
responses because the returned id's from a SORT or THREAD request doesn't
match the number of messages inside a mailbox. A very quick ugly
workaround for that problem was patching SM by doing 1:42... (32bit
unsigned integer) instead of 1:* inside imap_messages.php. That workaroun=
d
will not be commited to CVS because supporting broken servers is not
something I prefer. You can also switch off uid-support and see if that
will change the thread-view behaviour. If that will fix it I advise to
upgrade your UW install because using webmail without making use of UID's
is not recommanded.

Regards,

Marc Groot Koerkamp