Re: [SM-DEVEL] couldn't write default config

[Erin S. <si...@ha...>]

> Hello Peter,
>
> I'm having the same problem; prefs.php prepens SM_PATH to my data dir,
> so my prefs file becomes "..//var/local/webmail/data/thijs.pref", which
> is of course not the right location.
>
> I think this whole SM_PATH thing has been put through before carefully
> analysing the consequences this has throughout the code. I don't really
> see why all this is neccesary. Please inform me what problem is solved
> by this; from my viewpoint it has only introduced problems.
>
>
> Thijs

Peter, Thijs -

Ths SMPATH activity has been directed at removing relative path references
so that it isn't as confusing to reference files. The trouble comes when
SMPATH changes are not made correctly.

In this case, the update was made to the path of the datafile WITHOUT
consideration of the implications, and without the correct testing to
verify that the changes were, in fact, correct.  The datadir is NOT
required to be in the SM tree, therefore Having the SMPATH arbitrarily
prepended is outright wrong (and even if it were right, they obviously
didn't follow through enough to remove the relative directory assignment
they were supposed to be replacing in the first place).

In any case, the SMPATH in and of itself will make finding things much
easier (you don't have to worry about where exactly you are when you've
been included by file xyz or maybe file ../abc, or file 123/def), but it
has to be used correctly to begin with.

Don't fault the design when it's bad implementation that caused the problem.

Erin
(sizzle)

--
Waste of a good apple. - Samwise Gamgee
ICQ: 36870353