Re: [SM-DEVEL] User Defined Envelope From?

[Robin R. <ro...@ra...>]

Easy peasy... enclosed are the diffs on smtp.php to fix this (based on 1.2.5 base). I
made a new function that is called by both sendmail and SMTP code.

Will this find it's way into CVS?

Robin

Robin Rainton said:
> Ah... I have to use sendmail as my ISP's SMTP server won't accept connections
> unless you've checked your POP mail less than 10 minutes earlier - I know there's
> a technical term for this but I don't recall :-\
>
> However thanks to your tip I notice this this in the sendSMTP function:
>
>    if (isset($identity) && $identity != 'default') {
>        $from_addr = getPref($data_dir, $username, 'email_address' . $identity);
>    }
>    else {
>        $from_addr = getPref($data_dir, $username, 'email_address');
>    }
>
>    if (!$from_addr) {
>        $from_addr = "$popuser@$domain";
>    }
>
> Whereas all there is in the sendSendmail is:
>
>    $envelopefrom = "$popuser@$domain";
>
> So... looks to me like part from the sendSMTP function should be made a function
> itself, that is called by them both, no?
>
> If the powers that be (Konstantin?) think this is a real bug will you enter it
> into your tracking system?
>
> I'll happily play with it and patch it myself if you like - but this is so
> trivial I guess the owners of the code can sort it out in a flash ;-)
>
> Cheers,
>
> Rob
>
> Tracy McKibben wrote:
>
>> This was just discussed on one of the lists...  Do you have SM configured to use
>> sendmail, or SMTP?  The previous poster solved his problem by changing from
>> "sendmail" to "SMTP".
>>
>>
>> Robin Rainton said:
>>
>>>Hi people,
>>>
>>>One of my users is giving me grief because they want the envolope from address
>>>on sent mail to be the same as is set in their personal
>>>preferences 'From:' field, and not user@my_domain. Even though they have 'From:'
>>>and 'Reply to:' set to the same address, some systems ignore these and grab the
>>>address from the envelope.
>>>
>>>I think this could be achieved with a little hack to smtp.php, but wonder why
>>>this hasn't been done before, or at least made an option? I assume it's a bit of
>>>paranoia to protect against brain damaged users and nothing more sinister?
>>>
>>>I'd like to see this made configurable by the site admin (like, yeah - I trust
>>>my users to put the correct thing in 'From:' field, or no I don't).
>>>
>>>Is there anyone else who could use this? Any other ideas?
>>>
>>>Regards,
>>>
>>>Robin