Re: [SM-DEVEL] Reference header update

[Christian S. <chr...@os...>]

Jason Munro wrote:
> 
> I created a get_reference_header function in
> imap_messages to return the header lines. This was needed since
> references can span more than one header line.

All header fields may span more than a line. For instance are the
following two headers equivalent:

Subject: This is a test

Subject: This is
 a test

I submitted a patch to this mailing list a week ago that should do
general unfolding of multi-line headers (as described in RFC2822 section
2.2.3) in sqimap_get_small_header_list and sqimap_get_header. This may
eliminate special handling of the References-header.

However, nobody has responded to my post. Is this the wrong way to
submit patches?

I just noticed that my CVS checkout was for some old version of
SquirrelMail (by mistake I must have copied the wrong line from
http://www.squirrelmail.org/download.php and hence have checked out the
1.1 branch instead *blush*), so the patches were not really usable
anyway. I have attached an updated patch. Will somebody please review
this and check it into CVS (or tell me the right procedure for
submitting patches)?

The fact that header lines are not correctly unfolded becomes visible
when I receive mail with a subject containing non-us-ascii characters.
The non-us-ascii characters are encoded like this "=?iso-8859-1?Q?=E9?="
(I don't recall the name of this encoding), so even a very short subject
easily gets long in encoded form and hence the subject line is folded.


Christian