[SM-CVS] CVS: squirrelmail/src read_body.php,1.234,1.235

[Paul J. T. <th...@us...>]

Update of /cvsroot/squirrelmail/squirrelmail/src
In directory usw-pr-cvs1:/tmp/cvs-serv16721/src

Modified Files:
	read_body.php 
Log Message:
First, more formatting conventions.

  1. Wrap all operands of a complex expression with parentheses.
     For instance:
         if ($bob == 'foo' || $bob == 'bar') {
     is wrong. Do this instead:
         if (($bob == 'foo') || ($bob == 'bar')) {

  2. Carefully decide between pre and post incrementation. If it
     does not matter, always choose pre because it is technically
     more efficient. For instance:
         for ($i = 0; $i < $count; $i++) {
     is wrong. Do this instead:
         for ($i = 0; $i < $count; ++$i) {

  3. Classes should be named in style like this:
         MessageHeader
         Rfc8222Header
     etc. When there is an acronym at the beginning, treat it
     like a word - do NOT captitalize each letter of the acronym.

  4. Put each class in a seperate file named ClassName.class.php.
     Related classes can be put in one directory and then included
     in a main include file.

Second, big changes with mime.class.php here. And I don't think I broke
anything. (Sounds like famous last words, eh?)


Index: read_body.php
===================================================================
RCS file: /cvsroot/squirrelmail/squirrelmail/src/read_body.php,v
retrieving revision 1.234
retrieving revision 1.235
diff -u -w -r1.234 -r1.235
--- read_body.php	24 Aug 2002 05:38:31 -0000	1.234
+++ read_body.php	29 Aug 2002 23:42:46 -0000	1.235
@@ -589,7 +589,7 @@
       $message = $message->parent;
    }
    $read = sqimap_run_command ($imapConnection, "FETCH $passed_id BODY[$passed_ent_id.HEADER]", true, $response, $msg, $uid_support);
-   $rfc822_header = new rfc822_header();
+   $rfc822_header = new Rfc822Header();
    $rfc822_header->parseHeader($read);
    $message->rfc822_header = $rfc822_header;
 } else {