Collapsable Folders Problem

[Paul J. T. <cap...@sq...>]

<quote who="Wouter Teepe">
> Yes, the formatting of the collapseable folders is corrupted. In
> rc1 it was ok, but in rc2 it went wrong. You (peter) forwarded my
> (awesomely simple) patch some weeks ago to the -devel list, but
> as far as I can see nobody picked it up.
>
> To the best of my knowledge, the collapseable folders look
> *really* ugly in rc2, due to a small problem that always occurs.
> Please somebody fix it, because collapseable folders can be such
> a beauty.

Nobody touch this code yet. I am using the most current version of
CVS, which I believe to be the same as RC2, and am having no
problem with collapsable folders.

I think there might be more to this problem then we realize. Let's
look into it more thoroughly before anyone breaks anything more.

> The person who edited the FoldLink in left_main.php between the
> rc1 and the rc2 release should be able to confirm/understand this
> bug. This is what I wrote some weeks ago on the subject:
>
> -------
> with the collapseable folders, the "+" and the "-" now appear on
> the right of the folder name, which I find not a feature, because
> with long folder names, now I have to horizontally scroll the
> left_main window. The lay-out of the tree is totally screwed up.

First of all, can you give us some more of an example as to what
you are talking about by "now appear on the right of the folder
name". I think that you mean things used to look like this:

  - INBOX
  +   foo1
      foo2
  -   foo3
  +     foo_a
        foo_b
        foo_c
  +   foo4

And they now look like this:

  - INBOX
    + foo1
      foo2
    - foo3
      + foo_a
        foo_b
        foo_c
    + foo4

If I am correct that this is what you are talking about, I am
afraid you are stuck with it, as far as I am concerned. Version #2
above is the standard way that tree widgets are displayed in the
computer
world. Version #1 is not. Presentation of trees in the style of #1
simply is unappealing to the eye and can make it hard to follow the
+'s and -'s to the folder the correspond to.

> The origin of it is in that in left_main.php, in the function
> FoldLink no longer (as opposed to rc1) directly echos the output,
> but returns it to some 20 lines up.

Secondly, the function FoldLink is by no means to be changed back
to a version in which it directly echos the output. Squirrelmail 1
is full of code applying such bad coding practices as this. The
reasoning for my stance here as follows.

There is a WELL-KNOWN concept in computer programing which calls
for code which applies logic to be seperated from code that handles
presentation. This makes it MUCH easier to follow things in
debugging and maintanence. In addition, NOT following this
principle makes code much more vulnerable to mistakes.

To put it short, logic functions should not EVER contain statements
that output directly to the web browser. All of this should be done
directly in the main script.

-- 
            Paul Joseph Thompson
            cap...@sq...