Thread: [Squirrel-sql-commits] SF.net SVN: squirrel-sql:[6162] trunk/sql12/fw/src/main/java/net/ sourcefor
A Java SQL client for any JDBC compliant database
Brought to you by:
colbell,
gerdwagner
From: <man...@us...> - 2011-02-21 21:35:17
|
Revision: 6162 http://squirrel-sql.svn.sourceforge.net/squirrel-sql/?rev=6162&view=rev Author: manningr Date: 2011-02-21 21:35:10 +0000 (Mon, 21 Feb 2011) Log Message: ----------- Don't add the default clause if the null clause is not also added. Modified Paths: -------------- trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java Modified: trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java =================================================================== --- trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java 2011-02-21 21:25:17 UTC (rev 6161) +++ trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java 2011-02-21 21:35:10 UTC (rev 6162) @@ -416,10 +416,18 @@ SqlGenerationPreferences prefs) { ArrayList<String> result = new ArrayList<String>(); - boolean addDefaultClause = true; + boolean addDefaultClause = false; boolean supportsNullQualifier = false; boolean addNullClause = false; + // In Ingres2006, these work: + // ALTER TABLE test1 ADD "nullint" integer + // ALTER TABLE test1 ADD "nullint" integer not null with default + // + // This doesn't: + // ALTER TABLE test1 ADD "nullint" integer with default + + String sql = DialectUtils.getAddColumSQL(column, this, This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <man...@us...> - 2011-05-24 00:54:35
|
Revision: 6270 http://squirrel-sql.svn.sourceforge.net/squirrel-sql/?rev=6270&view=rev Author: manningr Date: 2011-05-24 00:54:29 +0000 (Tue, 24 May 2011) Log Message: ----------- Ingres 2006 R3 doesn't support altering column nullability. Modified Paths: -------------- trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java Modified: trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java =================================================================== --- trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java 2011-05-24 00:42:29 UTC (rev 6269) +++ trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java 2011-05-24 00:54:29 UTC (rev 6270) @@ -246,7 +246,11 @@ */ public boolean supportsAlterColumnNull() { - return true; + // I see this on Ingres 2006 R3 when altering a column to be not null + // com.ingres.gcf.util.SqlEx: ALTER TABLE: invalid change of attributes on an ALTER COLUMN + // at com.ingres.gcf.jdbc.DrvObj.readError(DrvObj.java:844) + // at com.ingres.gcf.jdbc.JdbcStmt.readError(JdbcStmt.java:2412) + return false; } /** This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <man...@us...> - 2011-05-24 00:56:15
|
Revision: 6271 http://squirrel-sql.svn.sourceforge.net/squirrel-sql/?rev=6271&view=rev Author: manningr Date: 2011-05-24 00:56:09 +0000 (Tue, 24 May 2011) Log Message: ----------- Ingres 2006 R3 doesn't support altering column nullability. Modified Paths: -------------- trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java Modified: trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java =================================================================== --- trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java 2011-05-24 00:54:29 UTC (rev 6270) +++ trunk/sql12/fw/src/main/java/net/sourceforge/squirrel_sql/fw/dialects/IngresDialectExt.java 2011-05-24 00:56:09 UTC (rev 6271) @@ -261,8 +261,9 @@ public String[] getColumnNullableAlterSQL(TableColumnInfo info, DatabaseObjectQualifier qualifier, SqlGenerationPreferences prefs) { - String alterClause = DialectUtils.ALTER_COLUMN_CLAUSE; - return new String[] { DialectUtils.getColumnNullableAlterSQL(info, this, alterClause, true, qualifier, prefs) }; + int featureId = DialectUtils.COLUMN_NULL_ALTER_TYPE; + String msg = DialectUtils.getUnsupportedMessage(this, featureId); + throw new UnsupportedOperationException(msg); } /** This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |