Thread: [Squirrel-sql-commits] sql12/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/tab View
A Java SQL client for any JDBC compliant database
Brought to you by:
colbell,
gerdwagner
From: Rob M. <man...@us...> - 2008-07-12 14:28:39
|
Update of /cvsroot/squirrel-sql/sql12/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/tab In directory sc8-pr-cvs8.sourceforge.net:/tmp/cvs-serv11393/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/tab Modified Files: Tag: squirrel_2_6_branch ViewSourceTab.java Log Message: Bug 1958881: (Unable to see source of database views) Adjusted the query for view source to use underlying system tables instead of INFORMATION_SCHEMA.VIEWS, since this view cannot handle views that are greater than 4000 characters. Merged fix from trunk. Index: ViewSourceTab.java =================================================================== RCS file: /cvsroot/squirrel-sql/sql12/plugins/mssql/src/net/sourceforge/squirrel_sql/plugins/mssql/tab/ViewSourceTab.java,v retrieving revision 1.2 retrieving revision 1.2.6.1 diff -C2 -d -r1.2 -r1.2.6.1 *** ViewSourceTab.java 2 Dec 2006 02:04:11 -0000 1.2 --- ViewSourceTab.java 12 Jul 2008 14:28:36 -0000 1.2.6.1 *************** *** 42,52 **** String HINT = s_stringMgr.getString("ViewSourceTab.display"); } ! ! /** SQL that retrieves the data. */ ! private static final String SQL = ! "SELECT VIEW_DEFINITION "+ ! "FROM INFORMATION_SCHEMA.VIEWS "+ ! "WHERE TABLE_CATALOG = ? " + ! "AND TABLE_NAME = ?"; public ViewSourceTab() --- 42,58 ---- String HINT = s_stringMgr.getString("ViewSourceTab.display"); } ! ! /** ! * SQLServer's INFORMATION_SCHEMA.VIEWS VIEW_DEFINITION column only supports up to 4000 chars. This ! * query can return a result-set with multiple rows that should be concatenated. They should be correctly ! * ordered by the SYSCOMMENT.COLID field. ! */ ! private static final String BIGVIEW_SQL = ! "SELECT text FROM sysobjects o , syscomments c " + ! "where o.name = ? " + ! "and o.id = c.id " + ! "order by c.colid "; ! ! public ViewSourceTab() *************** *** 58,65 **** { ISession session = getSession(); ! PreparedStatement pstmt = session.getSQLConnection().prepareStatement(SQL); IDatabaseObjectInfo doi = getDatabaseObjectInfo(); ! pstmt.setString(1, doi.getCatalogName()); ! pstmt.setString(2, doi.getSimpleName()); return pstmt; } --- 64,70 ---- { ISession session = getSession(); ! PreparedStatement pstmt = session.getSQLConnection().prepareStatement(BIGVIEW_SQL); IDatabaseObjectInfo doi = getDatabaseObjectInfo(); ! pstmt.setString(1, doi.getSimpleName()); return pstmt; } |