Re: [Squashfs-devel] [PATCH] Fixing segfault from NULL return of getenv()

[Phillip L. <phi...@gm...>]

On Mon, Mar 15, 2010 at 1:46 AM, Daniel Harrison <nix...@gm...> wrote:
> Sorry, that patch apparently makes it not append anything.
>
> Nevermind.

No problem.  I hit this issue on Ubuntu 9.10 last month, it's rather
strange as the code has worked without any problem since the first
release of Mksquashfs in 2002!   There's obviously been a behaviour
change in Ubuntu 9.10 (at least), and it may well be a bug in the
latest Ubuntu.

The solution is to switch to using getcwd(), this works in the normal
case and in the case of changed behaviour where PWD is undefined.  I
checked a fix for this into Squashfs CVS last month.  If you need the
fix, it's probably worth getting the latest Mksquashfs from CVS.

cvs -d:pserver:ano...@sq...:/cvsroot/squashfs login

cvs -z3 -d:pserver:ano...@sq...:/cvsroot/squashfs
co -P squashfs

Thanks

Phillip

> --
> Dan Harrison
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Squashfs-devel mailing list
> Squ...@li...
> https://lists.sourceforge.net/lists/listinfo/squashfs-devel
>