Re: [Squashfs-devel] [PATCH] squashfs: Handle progress bar when max == 0

[Geert U. <Gee...@so...>]

On Mon, 6 Apr 2009, Phillip Lougher wrote:
> On Mon, Apr 6, 2009 at 5:09 PM, Geert Uytterhoeven
> <Gee...@so...> wrote:
> > On Sun, 5 Apr 2009, Matthew L. Creech wrote:
> >> The simple test case:
> >>
> >> mkdir xxx
> >> touch xxx/1
> >> touch xxx/2
> >> mksquashfs xxx squash.img
> >> unsquashfs squash.img
> >>
> >> fails with a FP exception due to div-by-0 in progress_bar().  Move the
> >> initialization of variables that depend on 'max' below a check for the
> >> special case (max==0).
> >
> > Confirmed, and your patch fixed it.
> >
> > BTW, unsquashfs seems to work on 32-bit little endian only.
> > On anything else (I tried amd64, ppc32, ppc64), I always get:
> 
> Release was tested on 32-bit and 64-bit little endian (x86/amd64) and
> 32-bit big endian (ppc32). All bugs that showed up in my testing were
> fixed otherwise I wouldn't have released it.  Maybe you have found
> something which my testing didn't pick up, despite testing for a week
> and fixing the bugs that arose.
> 
> Sods law, you can test and test, release and someone always pops up
> with something you forgot to test.
> 
> Can you send the filesystem, or at least say what options you used to
> mksquashfs to create it, otherwise it's pure guess work as to what's
> the problem.

I just did the above sequence posted by Matthew.

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Gee...@so...
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010