[SQL-CVS] [ sqlobject-Patches-1535941 ] Sybase and LIMIT

[SourceForge.net <no...@so...>]

Patches item #1535941, was opened at 2006-08-07 16:56
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1535941&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: Eddie (eddie0uk)
>Assigned to: Oleg Broytmann (phd)
Summary: Sybase and LIMIT

Initial Comment:
In SybaseConnection it reads:

    def _queryAddLimitOffset(self, query, start, end):
        # XXX Sybase doesn't support LIMIT
        return query

Sybase does support LIMIT. I suggest having something like:

    def _queryAddLimitOffset(self, query, start, end):
        if end:
           return "SET ROWCOUNT %i %s SET ROWCOUNT 0" %
(end, query)
        return query

Cheers,

eddie

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-11 18:07

Message:
Logged In: YES 
user_id=4799

Well, it is better than nothing. Thank you!

Applied in the revision 1852 to the trunk, rev. 1853 to the
0.7-branch.

PS. Are you sure there is no need for semicolons:

SET ROWCOUNT %i; %s; SET ROWCOUNT 0

???

----------------------------------------------------------------------

Comment By: Eddie (eddie0uk)
Date: 2006-08-09 19:24

Message:
Logged In: YES 
user_id=1570436

Not that I am aware of.


----------------------------------------------------------------------

Comment By: Oleg Broytmann (phd)
Date: 2006-08-09 19:20

Message:
Logged In: YES 
user_id=4799

You do not use "start" parameter. Do Sybase has a notion of
offset?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1535941&group_id=74338