[SQL-CVS] [ sqlobject-Bugs-1953896 ] Limit doesn't work in sqlbuilder

[SourceForge.net <no...@so...>]

Bugs item #1953896, was opened at 2008-04-29 09:38
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1953896&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: SQLObject release (specify)
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: RicMoo (ricmoo)
>Assigned to: Oleg Broytmann (phd)
Summary: Limit doesn't work in sqlbuilder

Initial Comment:
There is a name error in the sqlbuilder for the Select class.

Line 674 of sqlbuilder (0.10.0) reads:
            end = start + limit

And no variable is named limit. Instead, it should be:
            end = start + self.ops['limit']

If you try to use limit in a Select() constructor, you receive a NameError when you request the SQL be generated.

I have made this change locally to my version, and it works wonderfully, however I am not sure how to create patches. Hopefully somemone will pick this up as low hanging fruit.

Thanks,

RicMoo

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2008-04-29 18:31

Message:
Logged In: YES 
user_id=4799
Originator: NO

Fixed in the revisions 3402, 3403 (branch 0.10 and the trunk). Thank you!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1953896&group_id=74338