Re: [SQLObject] Release of a transaction connection

[Luke O. <lu...@me...>]

I've attached a new test.

Here's the patch, which makes the tests pass for me on postgres:


Index: sqlobject/dbconnection.py
===================================================================
--- sqlobject/dbconnection.py   (revision 1365)
+++ sqlobject/dbconnection.py   (working copy)
@@ -857,6 +857,8 @@

      def _makeObsolete(self):
          self._obsolete = True
+        if self._dbConnection.autoCommit:
+            self._dbConnection._setAutoCommit(self._connection, 1)
          self._dbConnection.releaseConnection(self._connection,
                                               explicit=True)
          self._connection = None
@@ -867,6 +869,7 @@
          assert self._obsolete, "You cannot begin a new transaction session
without rolling back this one"
          self._obsolete = False
          self._connection = self._dbConnection.getConnection()
+        self._dbConnection._setAutoCommit(self._connection, 0)

      def __del__(self):
          if self._obsolete:


Quoting Oleg Broytmann <ph...@ma...>:

> On Wed, Dec 07, 2005 at 10:47:39AM -0600, Luke Opperman wrote:
>> begin() needs to set it back to 0.
>>
>> >On Sun, Dec 04, 2005 at 04:30:06PM +0800, Yuan HOng wrote:
>> >>     def _makeObsolete(self):
>> >>         self._obsolete = True
>> >>+        if self._dbConnection.autoCommit:
>> >>+            self._dbConnection._setAutoCommit(self._connection, 1)
>> >>         self._dbConnection.releaseConnection(self._connection,
>> >>                                              explicit=True)
>> >>         self._connection = None
>
>    I'd like to get a patch and tests.
>
> Oleg.