Re: [Sqlalchemy-tickets] [sqlalchemy] #1926: Patch for letting multiple engines and pools use a sin
Brought to you by:
zzzeek
From: sqlalchemy <mi...@zz...> - 2010-11-17 22:33:05
|
#1926: Patch for letting multiple engines and pools use a single stdlib logger each -------------------------+-------------------------------------------------- Reporter: guest | Owner: zzzeek Type: enhancement | Status: new Priority: medium | Milestone: 0.7.0 Component: engine | Severity: major - 1-3 hours Keywords: | Status_field: in queue -------------------------+-------------------------------------------------- Comment(by guest): Replying to [comment:2 zzzeek]: > and the logging works. Your patch removes the call to `default_logging()`, so the above script fails. Unusually, it actually dies with the message 'No handlers could be found for logger "sqlalchemy.engine.base.Engine"', and no stack trace or anything ! not sure what's causing that yet, that seems exceedingly unusual that there would be no stack trace. I missed the default_logging() call - an oversight, as I was concentrating on mapping echo values to logging levels while keeping just a single logger. No script should actually die after printing that message, though no logging will occur because no handlers were available: it's a one-off message to guard against accidental misconfiguration, and is only printed once. As there's no exception raised, there's no stack trace. Ideally libraries should not add handlers automatically - usually it should be up to the application developer to configure handlers - and it's not ideal that setting the echo flag both sets verbosity and adds a handler - though you may be constrained from changing anything here because of backward compatibility. -- Ticket URL: <http://www.sqlalchemy.org/trac/ticket/1926#comment:4> sqlalchemy <http://www.sqlalchemy.org/> The Database Toolkit for Python |