[Sqlalchemy-commits] sqlalchemy: - plug a minor ORM speed hit in Events (**kwargs).

[<co...@sq...>]

details:   http://hg.sqlalchemy.org/sqlalchemy/rev/d829e3adea6e
changeset: 6146:d829e3adea6e
user:      Ga?tan de Menten <ge...@op...>
date:      Sun Mar 07 20:45:39 2010 +0100
description:
- plug a minor ORM speed hit in Events (**kwargs).
- added comment explaining some strange code

diffstat:

 lib/sqlalchemy/orm/attributes.py |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (22 lines):

diff -r 3fc93b46a053 -r d829e3adea6e lib/sqlalchemy/orm/attributes.py
--- a/lib/sqlalchemy/orm/attributes.py	Sun Mar 07 10:56:11 2010 -0500
+++ b/lib/sqlalchemy/orm/attributes.py	Sun Mar 07 20:45:39 2010 +0100
@@ -883,14 +883,16 @@
 class Events(object):
     def __init__(self):
         self.original_init = object.__init__
+        # Initialize to tuples instead of lists to minimize the memory 
+        # footprint
         self.on_init = ()
         self.on_init_failure = ()
         self.on_load = ()
         self.on_resurrect = ()
 
-    def run(self, event, *args, **kwargs):
+    def run(self, event, *args):
         for fn in getattr(self, event):
-            fn(*args, **kwargs)
+            fn(*args)
 
     def add_listener(self, event, listener):
         # not thread safe... problem?  mb: nope