[Sqlalchemy-commits] [6057] sqlalchemy/branches/rel_0_6: enabled missing reflection tests
Brought to you by:
zzzeek
Menu
▾
▴
[Sqlalchemy-commits] [6057] sqlalchemy/branches/rel_0_6: enabled missing reflection tests
|
From: <co...@sq...> - 2009-06-13 19:29:24
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; } #msg dt:after { content:':';} #msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: bold} #msg dl a:link { color:#fc3; } #msg dl a:active { color:#ff0; } #msg dl a:visited { color:#cc6; } h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; } #msg ul, pre { overflow: auto; } #header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; } #patch { width: 100%; } #patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;} #patch .propset h4, #patch .binary h4 {margin:0;} #patch pre {padding:0;line-height:1.2em;margin:0;} #patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;} #patch .propset .diff, #patch .binary .diff {padding:10px 0;} #patch span {display:block;padding:0 10px;} #patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, .info {color:#888;background:#fff;} --></style> <title>[6057] sqlalchemy/branches/rel_0_6: enabled missing reflection tests</title> </head> <body> <div id="msg"> <dl> <dt>Revision</dt> <dd>6057</dd> <dt>Author</dt> <dd>zzzeek</dd> <dt>Date</dt> <dd>2009-06-13 15:29:19 -0400 (Sat, 13 Jun 2009)</dd> </dl> <h3>Log Message</h3> <pre>enabled missing reflection tests</pre> <h3>Modified Paths</h3> <ul> <li><a href="#sqlalchemybranchesrel_0_6libsqlalchemydialectssqlitebasepy">sqlalchemy/branches/rel_0_6/lib/sqlalchemy/dialects/sqlite/base.py</a></li> <li><a href="#sqlalchemybranchesrel_0_6libsqlalchemyschemapy">sqlalchemy/branches/rel_0_6/lib/sqlalchemy/schema.py</a></li> <li><a href="#sqlalchemybranchesrel_0_6testenginetest_reflectionpy">sqlalchemy/branches/rel_0_6/test/engine/test_reflection.py</a></li> </ul> </div> <div id="patch"> <h3>Diff</h3> <a id="sqlalchemybranchesrel_0_6libsqlalchemydialectssqlitebasepy"></a> <div class="modfile"><h4>Modified: sqlalchemy/branches/rel_0_6/lib/sqlalchemy/dialects/sqlite/base.py (6056 => 6057)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/branches/rel_0_6/lib/sqlalchemy/dialects/sqlite/base.py 2009-06-13 03:39:27 UTC (rev 6056) +++ sqlalchemy/branches/rel_0_6/lib/sqlalchemy/dialects/sqlite/base.py 2009-06-13 19:29:19 UTC (rev 6057) </span><span class="lines">@@ -501,7 +501,7 @@ </span><span class="cx"> indexes.append(dict(name=row[1], column_names=[], unique=row[2])) </span><span class="cx"> # loop thru unique indexes to get the column names. </span><span class="cx"> for idx in indexes: </span><del>- c = connection.execute("%sindex_info(%s)" % (pragma, idx['name'])) </del><ins>+ c = connection.execute("%sindex_info(%s)" % (pragma, quote(idx['name']))) </ins><span class="cx"> cols = idx['column_names'] </span><span class="cx"> while True: </span><span class="cx"> row = c.fetchone() </span></span></pre></div> <a id="sqlalchemybranchesrel_0_6libsqlalchemyschemapy"></a> <div class="modfile"><h4>Modified: sqlalchemy/branches/rel_0_6/lib/sqlalchemy/schema.py (6056 => 6057)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/branches/rel_0_6/lib/sqlalchemy/schema.py 2009-06-13 03:39:27 UTC (rev 6056) +++ sqlalchemy/branches/rel_0_6/lib/sqlalchemy/schema.py 2009-06-13 19:29:19 UTC (rev 6057) </span><span class="lines">@@ -559,10 +559,6 @@ </span><span class="cx"> if args: </span><span class="cx"> coltype = args[0] </span><span class="cx"> </span><del>- # adjust for partials - if util.callable(coltype): - coltype = args[0]() - </del><span class="cx"> if (isinstance(coltype, types.AbstractType) or </span><span class="cx"> (isinstance(coltype, type) and </span><span class="cx"> issubclass(coltype, types.AbstractType))): </span></span></pre></div> <a id="sqlalchemybranchesrel_0_6testenginetest_reflectionpy"></a> <div class="modfile"><h4>Modified: sqlalchemy/branches/rel_0_6/test/engine/test_reflection.py (6056 => 6057)</h4> <pre class="diff"><span> <span class="info">--- sqlalchemy/branches/rel_0_6/test/engine/test_reflection.py 2009-06-13 03:39:27 UTC (rev 6056) +++ sqlalchemy/branches/rel_0_6/test/engine/test_reflection.py 2009-06-13 19:29:19 UTC (rev 6057) </span><span class="lines">@@ -571,7 +571,7 @@ </span><span class="cx"> m9.reflect() </span><span class="cx"> self.assert_(not m9.tables) </span><span class="cx"> </span><del>- @testing.fails_on_everything_except('postgres', 'mysql') </del><ins>+ @testing.fails_on_everything_except('postgres', 'mysql', 'sqlite') </ins><span class="cx"> def test_index_reflection(self): </span><span class="cx"> m1 = MetaData(testing.db) </span><span class="cx"> t1 = Table('party', m1, </span><span class="lines">@@ -878,7 +878,7 @@ </span><span class="cx"> con.execute(sa.sql.text(query)) </span><span class="cx"> </span><span class="cx"> </span><del>-class ReflectionTest(TestBase): </del><ins>+class ComponentReflectionTest(TestBase): </ins><span class="cx"> </span><span class="cx"> @testing.fails_on('sqlite', 'no schemas') </span><span class="cx"> def test_get_schema_names(self): </span></span></pre> </div> </div> </body> </html> |