From: Mart K. <ma...@ke...> - 2008-11-11 20:04:46
|
Hi Brian (and others), Op Tuesday 11 November 2008 03:25:28 schreef Brian: > Hi Mart, > Great job! The build in Windows still works :) > > > Is it always neccesairy to add ${ROBOT_NAME}.def into the robot sources? > > If that is the case, I think it is better to change the macro. That way, > > the CMakeLists.txt keep simple. > > Yes .def is going to be need for all robots. How are those files generated? It would be nice if that file can be generated: people using Linux might not know what to put into that file. Looking to the some contents of such files, I think we can automatically generate those files (at least for robots). > > Why did you add the include_directories in CMakeLists.txt in the root > > directory? I didn't do that to only add the neccesairy include > > directories when neccesairy. It compiles now fine in Linux without those > > lines. > > I will try to change this. I saw you added ADD_INCLUDE_DIRECTORIES for the plib include dir in src/drivers. This make compilation in Linux fail: there is a js.h in /usr/include/plib/js.h and src/interfaces/js.h (and it picked the wrong one). > Brian Regards, Mart |