[Spades-sim-devel] [ spades-sim-Bugs-1641643 ] Number of clone arguments inconsistent

[SourceForge.net <no...@so...>]

Bugs item #1641643, was opened at 2007-01-22 08:44
Message generated for change (Comment added) made by patstg
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498859&aid=1641643&group_id=61929

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Agent Intercept Library
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Tim Niemueller (tniemueller)
Assigned to: Nobody/Anonymous (nobody)
Summary: Number of clone arguments inconsistent

Initial Comment:
In spades-config.h it reads

/* The number of arguments to clone */
#ifndef SPADES_NUM_CLONE_ARGS
#define SPADES_NUM_CLONE_ARGS  7
#endif

while in agent_intercept/override.cpp it reads

#ifdef SPADES_HAVE_CLONE
#if SPADES_NUM_CLONE_ARGS != 4

This will obviously fail. Workaround here is currently to change the original define to 4 instead of 7.


----------------------------------------------------------------------

>Comment By: Patrick Riley (patstg)
Date: 2007-01-23 23:51

Message:
Logged In: YES 
user_id=189652
Originator: NO

Hmm. It looks like you're right actually. This appears to be a relic from
an earlier version of this whole implementation. The comments at the top of
override indicate that we are now only supporting the 7 arg version of
clone.

----------------------------------------------------------------------

Comment By: Tim Niemueller (tniemueller)
Date: 2007-01-23 03:08

Message:
Logged In: YES 
user_id=55951
Originator: YES

You mean one of the dynlib-has-clone parameters? If that is the case it
seems not obvious to me that this will change the number of arguments.  Why
does it default to 7 when this renders the handling useless? Why is there a
config parameter anyway if it is only used in one place and it does only
work for exactly one value (I just had a short look into the code so please
pardon my ignorance)?

----------------------------------------------------------------------

Comment By: Patrick Riley (patstg)
Date: 2007-01-22 23:14

Message:
Logged In: YES 
user_id=189652
Originator: NO

I'm not sure what you're saying the problem is. SPADES_NUM_CLONE_ARGS is a
parameter to configure. If you want to change the value, pass something
different in to that script.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498859&aid=1641643&group_id=61929