From: SourceForge.net <no...@so...> - 2012-05-26 09:15:33
|
Bugs item #3476843, was opened at 2012-01-20 16:05 Message generated for change (Settings changed) made by uklauer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110706&aid=3476843&group_id=10706 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Ulrich Klauer (uklauer) Assigned to: Nobody/Anonymous (nobody) Summary: Invalid memory access within flac handler after seek Initial Comment: Command line: sox somefile.flac -n trim 20 10 Valgrind output (current SoX development version; happens both with old and new trim implementation): ==13973== Invalid read of size 8 ==13973== at 0x4E9A088: read_samples (flac.c:188) ==13973== by 0x4E4C3B8: sox_read (formats.c:972) ==13973== by 0x40A132: sox_read_wide (sox.c:474) ==13973== by 0x40A697: combiner_drain (sox.c:536) ==13973== by 0x4E5CDD5: sox_flow_effects (effects.c:318) ==13973== by 0x407C9B: process (sox.c:1786) ==13973== by 0x40311D: main (sox.c:3016) ==13973== Address 0x7fefffca0 is just below the stack ptr. To suppress, use: --workaround-gcc296-bugs=yes This seems to be related to seeking, since it only happens with optimize_trim; turning off the optimization by specifying two input files lets the error disappear: sox somefile.flac somefile.flac -n trim 20 10 There's no problem if somefile.wav is used instead, either. ---------------------------------------------------------------------- Comment By: eric_wong (eric_wong) Date: 2012-05-24 01:24 Message: I believe I have a fix for this issue, I can't figure out how to attach a patch, but you should be able to curl this to "git am" http://bogomips.org/sox.git/patch/?id=d469441154331de90df5bd0366fe4fd07b65535a You can also pull this from my git repo: git pull git://bogomips.org/sox flac-mem-access-3476843 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110706&aid=3476843&group_id=10706 |