Re: [SoX-devel] [ sox-Bugs-3082185 ] wrong RIFF chunk size in 24 bit wav?

[Chris B. <ch...@cn...>]

On Tue, Jan 4, 2011 at 6:50 PM, David Bryant <da...@wa...> wrote:
> I figured out why this is happening. The problem is that a 12-byte "fact"
> chunk is being added to files with extensible headers, but this is not being
> accounted for in a previous calculation for the total RIFF size.
>
> I am attaching a simple patch that fixes this in the safest possible way
> (makes the value correct without changing any other behavior). However, I
> don't really understand *why* the "fact" chunk is being written in this
> particular case; perhaps the correct solution is to simply eliminate the
> chunk.

Thanks so much for looking into this issue and providing patch.  After
seeing your fix, it looks like an obvious oversight length wasn't
updated.  So I'll commit the patch for sure.

On topic if it *should* write the "fact" chunk, I'll have to defer for
now.  I've little experience with apps using 24-bit wav files to
compare to and its been at least a couple of years since I looked into
related specs for extended format to know why we chose to write the
chunk.

If you hear any issues with apps processing that chunk then please let us know.

Chris