Menu
▾
▴
[SoX-devel] [ sox-Patches-2262177 ] sox does not builds: parsing of /etc/issue is not sane
|
From: SourceForge.net <no...@so...> - 2009-07-13 02:20:35
|
Patches item #2262177, was opened at 2008-11-11 12:38 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310706&aid=2262177&group_id=10706 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Volkov Peter (volkov_peter) Assigned to: Nobody/Anonymous (nobody) Summary: sox does not builds: parsing of /etc/issue is not sane Initial Comment: New version of sox attempts to get distribution name by parsing /etc/issue file. But the format of that file is not well defined - it's possible to put any text there, it's even possible to have escape characters there to have colors and etc etc... This case compilation problems like this one: http://bugs.gentoo.org/show_bug.cgi?id=246299 I suggest to allow us to have --with-distro=distro swith to avoid automatic parsing of /etc/issue file. See patch in attachment... ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2009-07-13 02:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: robs (robs) Date: 2009-06-28 14:26 Message: Fixed in 14.3.0 ---------------------------------------------------------------------- Comment By: robs (robs) Date: 2008-11-22 15:47 Message: Sorry for not getting back sooner. The patch is basically good: I've now added the --with-distro option but removed the original /etc/issue parsing code, so it's either --with-distro or the distro will not be specified. I need to add some words somewhere to encourage distros to use the new option as it helps with bug reports. There are now other changes in CVS configure.ac so I suggest you use your patch as is. Thanks for report/patch, Rob ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-11-22 08:16 Message: Guys any chances to review this patch? I want to include it in Gentoo, but I don't want to add random patches which will never accepted by upstream... thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310706&aid=2262177&group_id=10706 |