From: SourceForge.net <no...@so...> - 2008-02-17 20:43:57
|
Patches item #1667975, was opened at 2007-02-24 18:59 Message generated for change (Comment added) made by robs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310706&aid=1667975&group_id=10706 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Chris Bagwell (cbagwell) Assigned to: Nobody/Anonymous (nobody) Summary: Seek support for MP3 Initial Comment: Cedric Bregardis has posted the following patches to the sox-devel mailing list. They add seek support for MP3 and Ogg files. It also calculates length for MP3 files. The only downside I can see is that the MP3 version looks like its only going to work for CBR MP3's for both length calc and seeking... I suggest submitting but modify so that it only enables code for CBR files. Probably could look at Vorbis's seek() code to see how they are seeking on VBR files for some hints on how to correctly do this. ---------------------------------------------------------------------- >Comment By: robs (robs) Date: 2008-02-17 20:43 Message: Logged In: YES user_id=27473 Originator: NO seek support should be added similarly to the code now in mp3-duration.h ---------------------------------------------------------------------- Comment By: robs (robs) Date: 2007-05-18 19:21 Message: Logged In: YES user_id=27473 Originator: NO Vorbis done; mp3 not done; seek support should probably be added to MAD. ---------------------------------------------------------------------- Comment By: robs (robs) Date: 2007-05-10 19:17 Message: Logged In: YES user_id=27473 Originator: NO I'll do the vorbis one and see what can be done for mp3. ---------------------------------------------------------------------- Comment By: Chris Bagwell (cbagwell) Date: 2007-02-24 18:59 Message: Logged In: YES user_id=71218 Originator: YES File Added: sox-vorbisseek.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310706&aid=1667975&group_id=10706 |