From: Guy M. <gu...@ma...> - 2011-07-22 17:22:00
|
> On July 22, 2011, 3:02 p.m., Sebastian Trueg wrote: > > CMakeLists.txt, line 46 > > <http://git.reviewboard.kde.org/r/102032/diff/1/?file=27783#file27783line46> > > > > Why do we need a min rasqal version? Actually the only reason to search for rasqal is the include path and I am not even sure we need that. > > Do you run into compilation errors? because the version 0.9.21 makes a problem. There is a #if 0 at line 936 from /usr/include/rasqal/rasqal.h which disable the next line, defining raptor_message_handler. Is no more present at 0.9.26 - Guy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102032/#review4973 ----------------------------------------------------------- On July 21, 2011, 4:45 p.m., Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102032/ > ----------------------------------------------------------- > > (Updated July 21, 2011, 4:45 p.m.) > > > Review request for Soprano. > > > Summary > ------- > > The check of the rasqal version is missing. Actually 0.9.21 is too low. > > > Diffs > ----- > > CMakeLists.txt b393deb > > Diff: http://git.reviewboard.kde.org/r/102032/diff > > > Testing > ------- > > with cmake > > > Thanks, > > Guy > > |