From: Leandro S. <le...@fi...> - 2006-01-06 18:49:37
|
Hi, This one-liner makes smartctl detect SCSI IE errors properly on some of my SCSI disks, using smartctl's exit(2) status bits: Index: scsiprint.c =================================================================== RCS file: /cvsroot/smartmontools/sm5/scsiprint.c,v retrieving revision 1.100 diff -u -r1.100 scsiprint.c --- scsiprint.c 7 Dec 2005 02:53:52 -0000 1.100 +++ scsiprint.c 6 Jan 2006 18:33:57 -0000 @@ -1079,7 +1079,7 @@ else pout("TapeAlert Not Supported\n"); } else { /* disk, cd/dvd, enclosure, etc */ - if (res == scsiGetSmartData(fd, con->smartvendorattrib)) { + if ((res = scsiGetSmartData(fd, con->smartvendorattrib))) { if (-2 == res) returnval |= FAILSTATUS; else I also backported the whole IE and request sense-related fix to smartmontools-5.33 (patch attached). Leandro. |