From: Steve L. (JIRA) <ji...@sm...> - 2010-09-17 20:20:25
|
ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars --------------------------------------------------------------------------------------- Key: SFOS-1529 URL: http://jira.smartfrog.org/jira/browse/SFOS-1529 Project: SmartFrog Issue Type: Bug Components: .sfCore Affects Versions: 3.17.x Reporter: Steve Loughran Assignee: Julio Guijarro Fix For: 3.17.x The ComponentDescription code is meant to round trip, but if you create any attribute with a numeric key as a string, like, say "1", when it gets written it gets written as 1, which then fails in the parser. The fix: quote all attributes when written, as JSON serializers do. I intend to make this fix next week unless anyone vetoes it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.smartfrog.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Steve L. (JIRA) <ji...@sm...> - 2010-09-23 13:34:25
|
[ http://jira.smartfrog.org/jira/browse/SFOS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12290#action_12290 ] Steve Loughran commented on SFOS-1529: -------------------------------------- Problem is line 905 of org.smartfrog.sfcore.languages.sf.sfcomponentdescription.SFComponentDescriptionImpl, which goes ps.write(elem.toString()); it should get the string value and either quote every entry, or use its extensive knowlege of reserved words to quote things that need to be quoted > ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars > --------------------------------------------------------------------------------------- > > Key: SFOS-1529 > URL: http://jira.smartfrog.org/jira/browse/SFOS-1529 > Project: SmartFrog > Issue Type: Bug > Components: .sfCore > Affects Versions: 3.17.x > Reporter: Steve Loughran > Assignee: Patrick Goldsack > Fix For: 3.17.x > > > The ComponentDescription code is meant to round trip, but if you create any attribute with a numeric key as a string, like, say "1", when it gets written it gets written as 1, which then fails in the parser. > The fix: quote all attributes when written, as JSON serializers do. > I intend to make this fix next week unless anyone vetoes it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.smartfrog.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Patrick G. (JIRA) <ji...@sm...> - 2011-02-20 15:36:53
|
[ http://jira.smartfrog.org/jira/browse/SFOS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Goldsack resolved SFOS-1529. ------------------------------------ Resolution: Fixed > ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars > --------------------------------------------------------------------------------------- > > Key: SFOS-1529 > URL: http://jira.smartfrog.org/jira/browse/SFOS-1529 > Project: SmartFrog > Issue Type: Bug > Components: .sfCore > Affects Versions: 3.18.x > Reporter: Steve Loughran > Assignee: Patrick Goldsack > Priority: Critical > Fix For: 3.18.x > > > The ComponentDescription code is meant to round trip, but if you create any attribute with a numeric key as a string, like, say "1", when it gets written it gets written as 1, which then fails in the parser. > The fix: quote all attributes when written, as JSON serializers do. > I intend to make this fix next week unless anyone vetoes it. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Steve L. (JIRA) <ji...@sm...> - 2011-02-21 12:26:50
|
[ http://jira.smartfrog.org/jira/browse/SFOS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran closed SFOS-1529. -------------------------------- > ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars > --------------------------------------------------------------------------------------- > > Key: SFOS-1529 > URL: http://jira.smartfrog.org/jira/browse/SFOS-1529 > Project: SmartFrog > Issue Type: Bug > Components: .sfCore > Affects Versions: 3.18.x > Reporter: Steve Loughran > Assignee: Patrick Goldsack > Priority: Critical > Fix For: 3.18.x > > > The ComponentDescription code is meant to round trip, but if you create any attribute with a numeric key as a string, like, say "1", when it gets written it gets written as 1, which then fails in the parser. > The fix: quote all attributes when written, as JSON serializers do. > I intend to make this fix next week unless anyone vetoes it. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Steve L. (JIRA) <ji...@sm...> - 2011-02-21 12:27:02
|
[ http://jira.smartfrog.org/jira/browse/SFOS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12400#comment-12400 ] Steve Loughran commented on SFOS-1529: -------------------------------------- added a test, works for reserved words (true, extends) as well as integers and things with spaces and colons in. Closing the issue > ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars > --------------------------------------------------------------------------------------- > > Key: SFOS-1529 > URL: http://jira.smartfrog.org/jira/browse/SFOS-1529 > Project: SmartFrog > Issue Type: Bug > Components: .sfCore > Affects Versions: 3.18.x > Reporter: Steve Loughran > Assignee: Patrick Goldsack > Priority: Critical > Fix For: 3.18.x > > > The ComponentDescription code is meant to round trip, but if you create any attribute with a numeric key as a string, like, say "1", when it gets written it gets written as 1, which then fails in the parser. > The fix: quote all attributes when written, as JSON serializers do. > I intend to make this fix next week unless anyone vetoes it. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |