[Smartfrog-checkins] [Smartfrog.org-JIRA] Commented: (SFOS-1529) ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars

[Steve L. (JIRA) <ji...@sm...>]

    [ http://jira.smartfrog.org/jira/browse/SFOS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12400#comment-12400 ] 

Steve Loughran commented on SFOS-1529:
--------------------------------------

added a test, works for reserved words (true, extends) as well as integers and things with spaces and colons in. Closing the issue

> ComponentDescriptionImpl's writeOn method is broken, bad handling of non alphabet chars
> ---------------------------------------------------------------------------------------
>
>                 Key: SFOS-1529
>                 URL: http://jira.smartfrog.org/jira/browse/SFOS-1529
>             Project: SmartFrog
>          Issue Type: Bug
>          Components: .sfCore
>    Affects Versions: 3.18.x
>            Reporter: Steve Loughran
>            Assignee: Patrick Goldsack
>            Priority: Critical
>             Fix For: 3.18.x
>
>
> The ComponentDescription code is meant to round trip, but if you create any attribute with a numeric key as a string, like, say "1", when it gets written it gets written as 1, which then fails in the parser.
> The fix: quote all attributes when written, as JSON serializers do. 
> I intend to make this fix next week unless anyone vetoes it. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira