[Smartfrog-checkins] SF.net SVN: smartfrog:[8276] trunk/core/components/loggingservices/src/org/ smartfrog/services/logging/jcl/front/CommonsLogFactory.java

[<st...@us...>]

Revision: 8276
          http://smartfrog.svn.sourceforge.net/smartfrog/?rev=8276&view=rev
Author:   steve_l
Date:     2010-05-17 16:28:43 +0000 (Mon, 17 May 2010)

Log Message:
-----------
SFOS-1358 binding to commons logging appears to not work in sub-processes

Modified Paths:
--------------
    trunk/core/components/loggingservices/src/org/smartfrog/services/logging/jcl/front/CommonsLogFactory.java

Modified: trunk/core/components/loggingservices/src/org/smartfrog/services/logging/jcl/front/CommonsLogFactory.java
===================================================================
--- trunk/core/components/loggingservices/src/org/smartfrog/services/logging/jcl/front/CommonsLogFactory.java	2010-05-17 15:41:38 UTC (rev 8275)
+++ trunk/core/components/loggingservices/src/org/smartfrog/services/logging/jcl/front/CommonsLogFactory.java	2010-05-17 16:28:43 UTC (rev 8276)
@@ -22,9 +22,9 @@
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogConfigurationException;
 import org.apache.commons.logging.impl.LogFactoryImpl;
-import org.smartfrog.sfcore.logging.LogSF;
-import org.smartfrog.sfcore.logging.LogFactory;
 import org.smartfrog.sfcore.common.SmartFrogLogException;
+import org.smartfrog.sfcore.logging.LogFactory;
+import org.smartfrog.sfcore.logging.LogSF;
 
 /**
  * created 09-May-2006 17:17:53
@@ -47,13 +47,14 @@
 
     /**
      * To get the sfCore logger
+     *
      * @param name The name of the log to look for
      * @return Logger implementing LogSF and Log
      */
     private LogSF sfLog(String name) {
         try {
             //try to create a log and register it
-            return LogFactory.getLog(name,true);
+            return LogFactory.getLog(name, true);
         } catch (SmartFrogLogException e) {
             //if we can't register, get a simpler log
             return LogFactory.getLog(name);
@@ -62,26 +63,13 @@
 
 
     /**
-     * <p>Construct (if necessary) and return a <code>Log</code> instance,
-     * using the factory's current set of configuration attributes.</p>
-     * <p/>
-     * <p><strong>NOTE</strong> - Depending upon the implementation of
-     * the <code>LogFactory</code> you are using, the <code>Log</code>
-     * instance you are returned may or may not be local to the current
-     * application, and may or may not be returned again on a subsequent
-     * call with the same name argument.</p>
-     *
-     * @param name Logical name of the <code>Log</code> instance to be
-     *             returned (the meaning of this name is only known to the underlying
-     *             logging implementation that is being wrapped)
-     * @throws org.apache.commons.logging.LogConfigurationException
-     *          if a suitable <code>Log</code>
-     *          instance cannot be returned
+     * Create a new instance of this log
+     * @param name
+     * @return a new log
+     * @throws LogConfigurationException
      */
-    public Log getInstance(String name) throws LogConfigurationException {
-
+    @Override
+    protected Log newInstance(String name) throws LogConfigurationException {
         return new CommonsLogFrontEnd(sfLog(name));
     }
-
-
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.