From: Martin L. <mar...@ea...> - 2015-01-27 18:43:18
|
On Tue, Jan 27, 2015 at 03:57:52PM +0100, Bartosz Golaszewski wrote: > > This is something we implemented in our command-line client for acme: > http://git.baylibre.com/pub/sjan/acme-suite/tree/scripts/acme_cli.py > > It's a feature that has been requested by our beta testers in order to > be able to measure power consumption over specific time and output > total average. Maybe we could introduce another option that would > affect averaging mode? Or limit the number of output averaged samples? > > BTW I can't seem to find the option for 'dropping Nth measurements' - > how do I enable it? I can see this is something you may want to get, but it doesn't follow that it should be done at the driver level. You've implemented it there in your command line client. The equivalent place in the sigrok stack would be in whatever program the end user runs - either sigrok-cli, pulseview, or some custom client that uses the C/C++/Python/Java APIs. The role of libsigrok is to provide a common API across all the various hardware devices, not to implement every operation a client program want to do with the data. The role of a libsigrok driver is even more limited - really it should be just advertising what hardware capabilities the device has, translating libsigrok API calls into the necessary protocol-specific commands to the device, and passing back the data received. Things like "average over all samples" or "drop all but every Nth sample" should really be implemented in the client, because there's nothing device-specific about them once you're using the libsigrok API. Regards, Martin |