Re: [sigrok-devel] [PATCH] beaglelogic: Implemented with soft triggers

[Peter S. <pe...@st...>]

Bert Vermeulen wrote:
> > +	maxch = (devc->sampleunit == BL_SAMPLEUNIT_8_BITS) ? 8 : NUM_CHANNELS;
> 
> According to
> https://github.com/abhishek-kakkar/BeagleLogic/wiki/sysfs-attributes-Reference
> you set the max number of channels -- 8 or 13 -- by echo'ing 0 or 1 into
> /sys/devices/virtual/misc/beaglelogic/sampleunit

My comment has nothing to do with sigrok, but please just make
settings be explicit. Why use 0 and 1 to represent 8 and 13?
The extra code required to test for 8 or 13 isn't too overwhelming.


//Peter