Re: [sigrok-devel] [PATCH 1/2] USBee DX support

[Bert V. <be...@bi...>]

On Thu, 19 Dec 2013 01:27:32 +0900, "Jong-Jin, Kim"
<jon...@gm...> wrote:

Hi Jong-Jin,

Some comments on your main patch, the fx2lafw-usbee-dx driver:

- There is a lot of duplicated code between fx2lafw and your driver, for
  obvious reasons. I see no real reason why we can't just integrate this
  functionality into the fx2lafw driver. The difference between the two
  types of devices is established at scan time, after all. Can you submit
  patches to fx2lafw instead, and patch one thing at a time? For example,
  first patch might be extensions to struct dev_context + scan, then the
  rest of api.c, and so on.

  Don't hesitate to introduce new source files as necessary. Also I saw you
  did some good refactoring -- the fx2lafw definitely needs it.

- The scanning you did using the different libusbx API calls is broken: it
  doesn't compile on older versions of libusb, such as 1.0.9 -- our minimal
  requirement up until now. However since we need this and a bunch of other
  features present in newer versions of libusbx, we've now upgraded the
  minimal required version to be 1.0.16. So you can count on
  libusb_get_port_number() and friends being available.


-- 
Bert Vermeulen        be...@bi...          email/xmpp