Re: [Shinken-devel] Unknown boolean values lead to exception in property.py pythonize(val)

[Hartmut G. <h.g...@go...>]

Hi,

+	if not val in _boolean_states:
+		print "Warning : '%s' is no valid boolean value. Using fallback '%s' instead." % (val, _boolean_fallback_state)
+		return _boolean_fallback_state


-1 for this patch.

If some text is not a boolean text, this is either a programming error
or an error in the config file. Both have to be fixed are the origin
place. Fall-backs are a bad solution IMHO.

-- 
Schönen Gruß - Regards
Hartmut Goebel
Dipl.-Informatiker (univ.), CISSP, CSSLP

Goebel Consult 
Spezialist für IT-Sicherheit in komplexen Umgebungen
http://www.goebel-consult.de

Monatliche Kolumne: http://www.cissp-gefluester.de/
Goebel Consult mit Mitglied bei http://www.7-it.de