Re: [Secureideas-base-devel] Commit from this morning
Brought to you by:
secureideas,
sinukas
From: Kevin J. <kjo...@se...> - 2004-10-12 00:46:27
|
Hi- See below....<grin> On Mon, 2004-10-11 at 17:21, Chris Shepherd wrote: > Kevin, I pulled these files down, and I wonder if it might simply be=20 > easier to set base_path to dirname(__FILE__) in base_conf.php since it=20 > will always point to the directory where base_conf.php is, which should=20 > be the root directory anyways. The base_url is a good idea, though not=20 > portable if you are trying to provide it through multiple domain=20 > addresses (not necessarily likely, but still a possibility). I suppose=20 > the question I have is what was broken/done poorly that prompted the=20 > insertion of these two variables into the global config? >=20 Damn... I don't know why I didn't think of that..... I tried to think of a way to handle the base_urlpath without making the person enter a full domain name... mainly for things like the NST and such... (since I hope other projects pick us up!) The main reason for this was to enable the addition of things like the /admin/ directory and the next iteration which hopefully will include a /installation/ directory. It will also enable us to use internationalization. I am not sure if that is something we want but this guy from Italy was interested in it. This way we are prepared with out having to redo a lot. > The new look looks pretty cool, however some of the text colour is off.=20 > For instance, the "Added x alert(s) to the Alert cache" message shows up=20 > somewhat difficult to read on that blue background, as its colour=20 > appears not to have changed. It needs a bit of tweaking, but the colour=20 > difference looks pretty nice. I agree on the Alert color.... And I feel that there is quite a bit to tweak. I just wanted to get it in there so everyone could comment. I have a couple php additions the guy sent this morning that I will try to get in.... Work is kicking my butt this week already so we will see how much I can accomplish and stay married.<grin> BTW I did want to make sure I thanked you Chris for all of the work you have been doing, I don't think I have mentioned it before. Thanks Kevin |