From: SourceForge.net <no...@so...> - 2008-10-25 21:12:01
|
Patches item #2195343, was opened at 2008-10-25 22:12 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Steven Borley (sjborley) Assigned to: Nobody/Anonymous (nobody) Summary: Headers fix for --std-c89 Initial Comment: I've found that compiling with --std-c89 often fails because the system headers contain C++ ('//') style comments. This patch goes some way to fixing this. This patch makes the headers in all the files in the top level include directory compatible with --std-c89. This still leaves some sub-directories with with files containing '//' style comments so some target remain with incompatibilities. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 |
From: SourceForge.net <no...@so...> - 2008-11-09 19:31:59
|
Patches item #2195343, was opened at 2008-10-25 23:12 Message generated for change (Comment added) made by maartenbrock You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Steven Borley (sjborley) Assigned to: Nobody/Anonymous (nobody) Summary: Headers fix for --std-c89 Initial Comment: I've found that compiling with --std-c89 often fails because the system headers contain C++ ('//') style comments. This patch goes some way to fixing this. This patch makes the headers in all the files in the top level include directory compatible with --std-c89. This still leaves some sub-directories with with files containing '//' style comments so some target remain with incompatibilities. ---------------------------------------------------------------------- Comment By: Maarten Brock (maartenbrock) Date: 2008-11-09 20:31 Message: Steven, For some reason I can no longer download attachments (I already reported it to SF). Would you please send the attachment for this and the previous patch to the developer list so I can take a look? Thanks, Maarten Brock ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 |
From: Raphael N. <rn...@we...> - 2008-11-09 19:50:15
Attachments:
comments.patch
|
On Sun, 09 Nov 2008 20:31:56 +0100, SourceForge.net <no...@so...> wrote: > For some reason I can no longer download attachments (I already reported > it to SF). Would you please send the attachment for this and the previous > patch to the developer list so I can take a look? > > Thanks, > Maarten Brock Please find the attachments of the tracker item ... well ... attached. Regards, Raphael |
From: Maarten B. <sou...@ds...> - 2008-11-09 19:59:18
|
Thanks Raphael, But how did you get your hands on this file? Were you, unlike me, able to download it from the tracker? Maarten > On Sun, 09 Nov 2008 20:31:56 +0100, SourceForge.net > <no...@so...> wrote: > > For some reason I can no longer download attachments (I already reported > > it to SF). Would you please send the attachment for this and the previous > > patch to the developer list so I can take a look? > > > > Thanks, > > Maarten Brock > > Please find the attachments of the tracker item ... well ... attached. > > Regards, > Raphael |
From: Raphael N. <rn...@we...> - 2008-11-09 20:15:55
|
On Sun, 09 Nov 2008 20:59:08 +0100, Maarten Brock <sou...@ds...> wrote: > Thanks Raphael, > > But how did you get your hands on this file? Were you, > unlike me, able to download it from the tracker? Yes, I didn't even have to log into SF; just followed the link (https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599) and was able to use the download link (http://sourceforge.net/tracker/download.php?group_id=599&atid=300599&file_id=298909&aid=2195343) at the bottom (old tracker style in use, also works with the new tracker for me). Regards, Raphael |
From: Maarten B. <sou...@ds...> - 2008-11-09 20:29:13
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head> <title></title> <meta http-equiv="content-type" content="text/html;charset=utf-8"/> <meta http-equiv="Content-Style-Type" content="text/css"/> </head> <body> <div align="left"> <font face="Arial" color="#7f0000" size="2"> <span style=" font-size:10pt"> > Yes, I didn't even have to log into SF;</span></font> </div> <div align="left"> <font face="Arial" color="#7f0000" size="2"> <span style=" font-size:10pt"> <br /> </span> </font> </div> <div align="left"> <font face="Courier New" size="2"> <span style=" font-size:10pt"> Aha, that's it! I cannot download attachments when logged in (both with old and new tracker style). What else are administrator rights for, right? Now I tried again after logging out and voila I can download it too.</span></font> </div> <div align="left"> <font face="Courier New" size="2"> <span style=" font-size:10pt"> <br /> </span> </font> </div> <div align="left"> <font face="Courier New" color="#7f0000" size="2"> <span style=" font-size:10pt"> > just followed the link</span></font> </div> <div align="left"> <font face="Courier New" color="#7f0000" size="2"> <span style=" font-size:10pt"> > (https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&g</span></font> </div> <div align="left"> <font face="Courier New" color="#7f0000" size="2"> <span style=" font-size:10pt"> > roup_id=599) and was able to use the download link</span></font> </div> <div align="left"> <font face="Courier New" color="#7f0000" size="2"> <span style=" font-size:10pt"> > (http://sourceforge.net/tracker/download.php?group_id=599&atid=300599&f</span></font> </div> <div align="left"> <font face="Courier New" color="#7f0000" size="2"> <span style=" font-size:10pt"> > ile_id=298909&aid=2195343) at the bottom (old tracker style in use,</span></font> </div> <div align="left"> <font face="Courier New" color="#7f0000" size="2"> <span style=" font-size:10pt"> > also works with the new tracker  for me). </span></font> </div> <div align="left"> <font face="Arial" color="#7f0000" size="2"> <span style=" font-size:10pt"> > </span></font> </div> <div align="left"> <font face="Arial" color="#7f0000" size="2"> <span style=" font-size:10pt"> > Regards,</span></font> </div> <div align="left"> <font face="Arial" color="#7f0000" size="2"> <span style=" font-size:10pt"> > Raphael</span></font> </div> <div align="left"> <font face="Arial" size="2"> <span style=" font-size:10pt"> <br /> </span> </font> </div> <div align="left"> <font face="Arial" size="2"> <span style=" font-size:10pt"> <br /> </span> </font> </div> <div align="left"> <font face="Arial" size="2"> <span style=" font-size:10pt"> Greets,</span></font> </div> <div align="left"> <font face="Arial" size="2"> <span style=" font-size:10pt"> Maarten</span></font> </div> </body> </html> |
From: Steven B. <ste...@pa...> - 2008-11-10 09:30:34
|
Maarten, On 9 Nov 2008, at 19:31, SourceForge.net wrote: > For some reason I can no longer download attachments (I already > reported > it to SF). Would you please send the attachment for this and the > previous > patch to the developer list so I can take a look? I didn't pick up your e-mail until this morning, but from reading later messages you now found a way to access the attachments. Let me now If you still want me to send any files to you. I updated the T600 etc. header patch on SourceForge this morning to avoid the use of c++ comments in the supplied files. I'd recommend the new version as the old ones will not compile with --std-c89. Regards, Steven |
From: SourceForge.net <no...@so...> - 2008-11-10 20:16:31
|
Patches item #2195343, was opened at 2008-10-25 23:12 Message generated for change (Settings changed) made by maartenbrock You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Steven Borley (sjborley) >Assigned to: Maarten Brock (maartenbrock) Summary: Headers fix for --std-c89 Initial Comment: I've found that compiling with --std-c89 often fails because the system headers contain C++ ('//') style comments. This patch goes some way to fixing this. This patch makes the headers in all the files in the top level include directory compatible with --std-c89. This still leaves some sub-directories with with files containing '//' style comments so some target remain with incompatibilities. ---------------------------------------------------------------------- Comment By: Maarten Brock (maartenbrock) Date: 2008-11-09 20:31 Message: Steven, For some reason I can no longer download attachments (I already reported it to SF). Would you please send the attachment for this and the previous patch to the developer list so I can take a look? Thanks, Maarten Brock ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 |
From: SourceForge.net <no...@so...> - 2008-11-10 20:16:49
|
Patches item #2195343, was opened at 2008-10-25 23:12 Message generated for change (Comment added) made by maartenbrock You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Steven Borley (sjborley) Assigned to: Maarten Brock (maartenbrock) Summary: Headers fix for --std-c89 Initial Comment: I've found that compiling with --std-c89 often fails because the system headers contain C++ ('//') style comments. This patch goes some way to fixing this. This patch makes the headers in all the files in the top level include directory compatible with --std-c89. This still leaves some sub-directories with with files containing '//' style comments so some target remain with incompatibilities. ---------------------------------------------------------------------- Comment By: Maarten Brock (maartenbrock) Date: 2008-11-10 21:16 Message: Applied in SDCC 2.8.4 #5263. Thank you. ---------------------------------------------------------------------- Comment By: Maarten Brock (maartenbrock) Date: 2008-11-09 20:31 Message: Steven, For some reason I can no longer download attachments (I already reported it to SF). Would you please send the attachment for this and the previous patch to the developer list so I can take a look? Thanks, Maarten Brock ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300599&aid=2195343&group_id=599 |