From: Johan K. <joh...@id...> - 2000-10-11 09:49:42
|
In sdcc/device/examples/ds390/i2c390 the file pcf8592.c the function ReadPCF8592. The first parameter (address) is seriously abused and ignored. It now results in a linker warning because ReadPCF8592_address_1_1 isn't declared. In a build of 18th-sep it was regsistered so the linker didn't warn, but was ignored as well in the assignment of id. Since in my example this was always zero it was not noticed. Johan |
From: Kevin V. <kv...@en...> - 2000-10-11 22:57:50
|
On 11-Oct-2000 Johan Knol wrote: > In sdcc/device/examples/ds390/i2c390 the file pcf8592.c the > function > ReadPCF8592. > The first parameter (address) is seriously abused and ignored. > It now results in a linker warning because ReadPCF8592_address_1_1 > isn't > declared. > In a build of 18th-sep it was regsistered so the linker didn't > warn, but was > ignored as well in the assignment of id. Since in my example this > was always > zero it was not noticed. There's a bug here, but I'm not sure it's a serious one. The real bug is that you have a trailing semicolon on your #define of PCF8591_ID in pcf8591.h. So the first line of ReadPCF8592 looks like this (after preprocessing): unsigned char id = 0x90; + address << 1; The trailing expression (+ address << 1) is a useless, but legal C statement (gcc happily compiles it without warning, as does SDCC). The optimizer (quite properly) throws it away. id always has a value of 0x90 (and again, the optimizer does the right thing and throws the variable away and replaces it with the constant 0x90). So the fact that address is unused isn't a bug in the compiler, in fact it's exactly right. The real problem is that if all references to a function parameter are removed by the optimizer, we still generate code to "receive" the parameter, but don't generate the data variable, causing the linker warning. This has previously been reported (Bug #108580 on the Sourceforge page). I have previously had a crack at fixing it, but I'm not confident in my fix, and would like to avoid fixing this one until we have cut 2.2.1 (I'd hate to destabilize it at this point, and I think this bug is easily enough worked around that we can ignore it for now; do we need a "known bugs" listing somewhere?) By the way, I took the liberty of checking in the fixed pcf8591.h. Peace, Kevin |
From: Johan K. <joh...@id...> - 2000-10-13 00:08:41
|
> So the fact that address is unused isn't a bug in the compiler, in > fact it's exactly right. Once again my bug report seemed to be related to my own programming flaws ;). Before reporting this bug I really have looked at my code over and over again but still missed the point you noticed, a semicolon in this case. If you look too hard, you get blind. But fortunately there is always someone to help you cross the street :). So, a construction like: mov dptr,#_ReadPCF8591_address_1_1 mov a,dpl movx @dptr,a obviously shows a flaw that still exists in the code-generator and not in the parser/optimizer. No offence meant. > This has previously been reported (Bug #108580 on the > Sourceforge page). I have previously had a crack at fixing it, but > I'm not confident in my fix, and would like to avoid fixing this one > until we have cut 2.2.1 (I'd hate to destabilize it at this point, >and I think this bug is easily enough worked around that we can > ignore it for now; do we need a "known bugs" listing somewhere?) I have a working copy with a --output-dir that makes it possible to build for different targets in the same source tree (e.g. the sdcc/device/lib) but am waiting for the 2.2.1 cut as well before ci-ing it. So, please let's get on with it. Now that I know that there IS a "known bugs" listing (there is even a "task" list!) I wonder why we don't really use it. I grabbed my 80C535 evaluation kit from the attick so I can now test also outside the scope of the ds390. I volunteer for library support (stdio and fp in particular) since there still is a lot of work to do. Johan |
From: Kevin V. <kv...@en...> - 2000-10-13 05:22:58
|
> So, a construction like: > > mov dptr,#_ReadPCF8591_address_1_1 > mov a,dpl > movx @dptr,a > > obviously shows a flaw that still exists in the code-generator and > not in > the parser/optimizer. No offence meant. Oh yes, there's clearly a bug; we shouldn't be doing the genReceive case at all when all accesses to the parameter have been optimized away. I hadn't noticed just how screwed-up that genReceive code was... no offense taken, that's some ugly stuff! I'm only resisting fixing this because the workaround is easy once you know the problem: don't have any meaningless references to a function parameter (if there are no references at all, it's fine; if the parameter is actually used, it's fine; it's only the case in which a function parameter is referenced in a useless way that the optimizer can remove that we have a problem, and that case can easily be avoided). So I don't think this bug is very serious. But it is definitely a bug, and I will do my best to fix it. (by the way, you don't want to know how long it too me to spot that semi-colon! I learned Pascal first (showing my age...) and my brain still just completely ignores semi-colons when reading...) > am waiting for the 2.2.1 cut as well before ci-ing it. So, please > let's get > on with it. I'd agree; Sandeep, anything we can do to expedite cutting a 2.2.1 release? > Now that I know that there IS a "known bugs" listing (there is even > a "task" > list!) I wonder why we don't really use it. Just not in tha habit, I guess. One thing: please send mail to the -devel list if you create a new bug/task (there were some bugs in the ds390 stuff that had been reported for months, and I had no idea that the bug reports were there; I wish Sourceforge had an option to mail me when a bug was created, but if there is one, I surely can't find it). Peace, Kevin |
From: Sandeep D. <sa...@dd...> - 2000-10-14 14:44:21
|
Yes , The genRecieve code is UGLY, primarily because I hacked in as an afterthought, The compiler was not initially designed to pass parameters in registers. As for 2.2.1 there is really nothing holding us. I will make a tar.gz of the source today. Dave I forgot where you want the file so that you can put it on the webpage. I need help building the Windows binaries. I don't have cygwin installed on any machine..... I will also tag CVS with the version number..... The tag will be V_2_2_1. Sandeep -----Original Message----- From: sdc...@li... [mailto:sdc...@li...]On Behalf Of Kevin Vigor Sent: Thursday, October 12, 2000 10:23 PM To: sdc...@li... Subject: RE: [sdcc-devel] Post 2.2.1 considerations. Was: Serious bug rep > So, a construction like: > > mov dptr,#_ReadPCF8591_address_1_1 > mov a,dpl > movx @dptr,a > > obviously shows a flaw that still exists in the code-generator and > not in > the parser/optimizer. No offence meant. Oh yes, there's clearly a bug; we shouldn't be doing the genReceive case at all when all accesses to the parameter have been optimized away. I hadn't noticed just how screwed-up that genReceive code was... no offense taken, that's some ugly stuff! I'm only resisting fixing this because the workaround is easy once you know the problem: don't have any meaningless references to a function parameter (if there are no references at all, it's fine; if the parameter is actually used, it's fine; it's only the case in which a function parameter is referenced in a useless way that the optimizer can remove that we have a problem, and that case can easily be avoided). So I don't think this bug is very serious. But it is definitely a bug, and I will do my best to fix it. (by the way, you don't want to know how long it too me to spot that semi-colon! I learned Pascal first (showing my age...) and my brain still just completely ignores semi-colons when reading...) > am waiting for the 2.2.1 cut as well before ci-ing it. So, please > let's get > on with it. I'd agree; Sandeep, anything we can do to expedite cutting a 2.2.1 release? > Now that I know that there IS a "known bugs" listing (there is even > a "task" > list!) I wonder why we don't really use it. Just not in tha habit, I guess. One thing: please send mail to the -devel list if you create a new bug/task (there were some bugs in the ds390 stuff that had been reported for months, and I had no idea that the bug reports were there; I wish Sourceforge had an option to mail me when a bug was created, but if there is one, I surely can't find it). Peace, Kevin _______________________________________________ sdcc-devel mailing list sdc...@li... http://lists.sourceforge.net/mailman/listinfo/sdcc-devel |
From: Kevin V. <ke...@vi...> - 2000-10-14 16:10:51
|
On 14-Oct-2000 Sandeep Dutta wrote: > I need help building the Windows binaries. I don't have cygwin > installed > on any machine..... I can do that once we have a tag or tarball. I can produce Borland C++ generated binaries, which gets us away from the dependancy on Cygwin (hooray!). Peace, Kevin |
From: Sandeep D. <sa...@dd...> - 2000-10-14 17:11:52
|
Great.. I will have a tag & targball by end of today. Iam working on a couple of bugs.. I think these need to be addressed with 2.2.1.... will send out an email as soon as I have them... PS Kevin .. I think SDCCopt.c fix is okay you can take out the #ifdef POST_2_2_1 Sandeep -----Original Message----- From: sdc...@li... [mailto:sdc...@li...]On Behalf Of Kevin Vigor Sent: Saturday, October 14, 2000 9:11 AM To: sdc...@li... Subject: RE: [sdcc-devel] Post 2.2.1 considerations. Was: Serious bug rep On 14-Oct-2000 Sandeep Dutta wrote: > I need help building the Windows binaries. I don't have cygwin > installed > on any machine..... I can do that once we have a tag or tarball. I can produce Borland C++ generated binaries, which gets us away from the dependancy on Cygwin (hooray!). Peace, Kevin _______________________________________________ sdcc-devel mailing list sdc...@li... http://lists.sourceforge.net/mailman/listinfo/sdcc-devel |
From: Kevin V. <kv...@en...> - 2000-10-14 17:19:37
|
On 14-Oct-2000 Sandeep Dutta wrote: > PS Kevin .. I think SDCCopt.c fix is okay you can take out > the #ifdef POST_2_2_1 OK, it's in; thanks! Peace, Kevin |
From: <da...@kd...> - 2000-10-14 23:28:05
|
On 14 Oct, Kevin Vigor said something like: > > On 14-Oct-2000 Sandeep Dutta wrote: >> I need help building the Windows binaries. I don't have cygwin >> installed >> on any machine..... > > I can do that once we have a tag or tarball. I can produce Borland > C++ generated binaries, which gets us away from the dependancy on > Cygwin (hooray!). > > Peace, > Kevin Good! Kevin, I made a directory on sourceforge for the new release *** everyone ***** earlier I said /groups/sdcc/blah...wrong! /home/groups/sdcc/v2.2.1 If you would be kind enough to place your build there. I would love to put it one the web page. A separate text file describing your build would be nice too. Something to read before the person downloads the build. Tnx -- Dave I come from the net.... I search through systems, people, and cities to find this place... mainframe, my home. My format: Guardian, to mend and defend. Reboot! --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet |
From: Johan K. <joh...@id...> - 2000-10-15 11:31:50
|
Perhaps you could change the release date to October 14 too. That is historicaly more correct and less confusing. Johan |
From: <da...@kd...> - 2000-10-15 13:54:49
|
On 15 Oct, Johan Knol said something like: > Perhaps you could change the release date to October 14 too. That is > historicaly more correct and less confusing. > > Johan Ok... it was late and I rushed a couple of things. Mostly the file names and links, I wanted them to at least work. Johan, your debugging the web page now...hehe. I will have your email address and the date corrected almost as soon as I press the send button. -- Dave I come from the net.... I search through systems, people, and cities to find this place... mainframe, my home. My format: Guardian, to mend and defend. Reboot! --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet |
From: Johan K. <joh...@id...> - 2000-10-15 19:08:54
|
> Johan, your debugging the web page now...hehe. Hi, I just LOVE bugs, but I mostly like them stuffed :) I do have a collection of real stuffed bugs, from the Cteocephalides Felis I grabbed from my cat to the Heliocopris Dominus I catched in Thailand during a holiday and smuggled back home in a bottle of Scotch ;). I should someday make a web page about this and introduce a new species: the (c) Kevinaris Vigorus (tm), under GPL license of course... |
From: <da...@kd...> - 2000-10-15 19:40:31
|
On 15 Oct, Johan Knol said something like: >> Johan, your debugging the web page now...hehe. > > Hi, I just LOVE bugs, but I mostly like them stuffed :) > > I do have a collection of real stuffed bugs, from the Cteocephalides Felis I > grabbed from my cat to the Heliocopris Dominus I catched in Thailand during > a holiday and smuggled back home in a bottle of Scotch ;). I should someday > make a web page about this and introduce a new species: the (c) Kevinaris > Vigorus (tm), under GPL license of course... > Does anyone on the list think we need a 'famous quotes' section in the web pages? ;-) -- Dave I come from the net.... I search through systems, people, and cities to find this place... mainframe, my home. My format: Guardian, to mend and defend. Reboot! --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet |
From: Sandeep D. <sa...@dd...> - 2000-10-15 19:55:24
|
>>Does anyone on the list think we need a 'famous quotes' section in the >>web pages? >>;-) Sure why not.. feel free ...have fun.... Here is mine. "GOD is REAL, unless declared as an INTEGER". read that somewhere on the net Sandeep -- Dave I come from the net.... I search through systems, people, and cities to find this place... mainframe, my home. My format: Guardian, to mend and defend. Reboot! --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet _______________________________________________ sdcc-devel mailing list sdc...@li... http://lists.sourceforge.net/mailman/listinfo/sdcc-devel |
From: Schmitt, M. <msc...@ba...> - 2000-10-16 11:35:42
|
a few days offline and great things happen ! is there a reason why the links for the new sdcc version do not contain the libs, includes, docs,... ? both links (web page and posted a few days agos) contain only the binaries (bin folder) 'famous quotes' here is mine Insane people throw computers out of windows, sane people... Dipl.-Ing. (FH) Michael Schmitt Baumer Ident GmbH Entwicklung / Development Department Hertzstr. 10 D-69469 Weinheim Deutschland / Germany Tel. +49 (0) 6201 9957 - 30 Fax. +49 (0) 6201 9957 - 99 E-Mail : msc...@ba... Web: http://www.baumerident.com |
From: <da...@kd...> - 2000-10-25 00:11:21
|
On 15 Oct, Sandeep Dutta wrote: >>>Does anyone on the list think we need a 'famous quotes' section in the >>>web pages? > >>>;-) > > Sure why not.. feel free ...have fun.... > > Here is mine. > > > "GOD is REAL, unless declared as an INTEGER". > > read that somewhere on the net > > Sandeep > My fav would have to be.... The difference between involvement and commitment is like an eggs and ham breakfast. The chicken was involved... the pig was committed. -- Dave --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet |
From: Sandeep D. <sa...@dd...> - 2000-10-15 19:33:45
|
Dave I put the source tar.gz in the directory you created. /home/groups/sdcc/v2.2.1/sdcc-2.2.1.tar.gz Once again, thanks for taking care of the web page Sandeep -----Original Message----- From: sdc...@li... [mailto:sdc...@li...]On Behalf Of da...@kd... Sent: Sunday, October 15, 2000 6:58 AM To: sdc...@li... Subject: Re: [sdcc-devel] v2.2.1 upload dir and Borland build On 15 Oct, Johan Knol said something like: > Perhaps you could change the release date to October 14 too. That is > historicaly more correct and less confusing. > > Johan Ok... it was late and I rushed a couple of things. Mostly the file names and links, I wanted them to at least work. Johan, your debugging the web page now...hehe. I will have your email address and the date corrected almost as soon as I press the send button. -- Dave I come from the net.... I search through systems, people, and cities to find this place... mainframe, my home. My format: Guardian, to mend and defend. Reboot! --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet _______________________________________________ sdcc-devel mailing list sdc...@li... http://lists.sourceforge.net/mailman/listinfo/sdcc-devel |
From: <da...@kd...> - 2000-10-14 23:11:41
|
On 14 Oct, Sandeep Dutta said something like: > > As for 2.2.1 there is really nothing holding us. I will make a tar.gz of the > source today. Dave I forgot where you want the file so that you can put > it on the webpage. > I need help building the Windows binaries. I don't have cygwin installed > on any machine..... > I will also tag CVS with the version number..... The tag will be V_2_2_1. > > Sandeep > I believe the path is /groups/sdcc/htdocs. I created a dir there for 2.2.0... I will ssh in tonight and create one for 2.2.1. Please place the tar file there. I'm afraid I can't help with a cygwin build either. I've been holding off on the web page updates for this release. No sense in saying ..RSN...more than once. If there is a 'Changes' file in CVS, I can't find it (haven't looked in a while either). It would be nice to have a link to one in the support section. Updated the "who's who" list, with kevin and johan. Moved old news to seperate page. LCD section added to links page. I don't know if anyone else seen this on Freshmeat the other day... it's worth checking out. I've been playing with it for a couple of days and really like it. http://www.cadsoftusa.com/betatest.htm -- Dave I come from the net.... I search through systems, people, and cities to find this place... mainframe, my home. My format: Guardian, to mend and defend. Reboot! --------------------------------------------------------------------------- Dave Helton, KD0YU - da...@re... - http://www.kd0yu.com Real World Computing - 319-386-4041 - 8am-5pm CST Linux/Novell/NT | Servers/Workstations | Consulting | Internet Technologies --------------------------------------------------------------------------- 'SYN! .. SYN|ACK! .. ACK!' - the mating call of the internet |
From: Johan K. <joh...@id...> - 2000-10-15 11:21:03
|
> Updated the "who's who" list, with kevin and johan. Moved old news to > seperate page. LCD section added to links page. Maybe you could change my email address to joh...@id... wich is more correct :) |
From: Kevin V. <ke...@vi...> - 2000-10-13 21:11:06
|
I had some time today, so I have found what I think is the proper fix for this bug (link errors caused by useless references to parameters). I have checked in the fix (to SDCCopt.c), but it's currently ifdef'd out with #ifdef POST_2_2_1 (even though I now think this is a pretty safe fix). I will remove this once 2.2.1 is out. If you want to test the fix in the meantime, just slap a #define POST_2_2_1 at the top of SDCCopt.c. Peace, Kevin |
From: Sandeep D. <sa...@dd...> - 2000-10-14 14:32:02
|
>> mov dptr,#_ReadPCF8591_address_1_1 >> mov a,dpl >> movx @dptr,a Yes this looks like a bug.. will take a look 2day.... >>Now that I know that there IS a "known bugs" listing (there is even a "task" >>list!) I wonder why we don't really use it. I grabbed my 80C535 evaluation >>kit from the attick so I can now test also outside the scope of the ds390. I >>volunteer for library support (stdio and fp in particular) since there still >>is a lot of work to do. Actually I do use it.. I think I knocked of about 6 last week.But lack of time is the most serious problem .. I wish there were more hours to a day and I could do with a little less sleep.... you are welcome to take on anything you think will make the compiler better.... Sandeep |