#3876 FW: Spaceship glitches in demo (regression)

[kirben]

ScummVM 0.13.0svn (Aug 18 2008 10:20:36)
Compiled under mingw with GCC 4.2.1-dw2
Running on Windows XP Media Center 2005 Edition
Amiga demo of Future Wars

The image of the top part of the spaceship isn't displayed correctly in the Amiga demo of Future Wars.

I expect this problem is due to a decode failure, since the following warnings are reported:
WARNING: Error unpacking 'L004.ANI' from bundle file 'DEMO'!
WARNING: _activeLowPal is invalid!

This problem is specific to ScummVM 0.13.0svn, and doesn't occur in the ScummVM 0.12.0pre branch.

[kirben]

[kirben]

[kirben]

Logged In: YES
user_id=34715
Originator: YES

File Added: scummvm0.12.0.png

[Kari Salminen]

Logged In: YES
user_id=1803212
Originator: NO

I changed unpacking not to unpack data in-place and the glitch
vanished so this seems to be caused by revision 33781 where
I changed readBundleFile to unpack data in-place (As that's what
the original also does AFAIK, but it would seem that I am wrong
on this).

Fixed in trunk in revision 34034:
http://scummvm.svn.sourceforge.net/scummvm/?rev=34034&view=rev

Fixed in branch-0-12-0 in revision 34035:
http://scummvm.svn.sourceforge.net/scummvm/?rev=34035&view=rev

SVN log message for the bugfix:

Fix for bug #2057637: FW: Spaceship glitches in demo (regression).
This was caused by assuming in-place decompression is ok, it wasn't,
although AFAIK the original did decompression in-place too.
Changed unpacking to be done not in-place and the glitch vanished.
Also changed the unpacker to also handle uncompressed input data.

[Kari Salminen]

Logged In: YES
user_id=1803212
Originator: NO

:D It *doesn't* occur on the 0.12.0pre branch, ooookay.
Well, the fix the I backported to the 0.12.0 branch makes
all unpacking to be done not in-place so it's a good precaution
anyway, shouldn't be any harm done (Knocks wood, knocks head).