Re: [Scst-devel] [PATCH] convert old bit flag use BH style

[Ming Z. <mi...@el...>]

the reason i do this is that i found code in 2.6.x mostly use *_bit()
instead of :1, for example. the qlogic code from 2.4 to 2.6 now use
_bit() as well. but frankly, i am not sure what is the benefit and
whether there is benefit at all. so that is why i said "follow style
better"

maybe i should send an email to a linux kernel list and seek for answer.

it is fine not to merge the patch. when u produce some thing, u can not
expect that it can be 100% sold. ;) 

ming


On Tue, 2006-02-28 at 18:49 +0300, Vladislav Bolkhovitin wrote:
> Actually, originally all bit fields in SCST were done using *_bit() 
> functions. Then I reimplemented them using native compiler ":1" bit 
> fields declarations, because:
> 
> 1. *_bit() functions are atomic (at least without "__" prefix), so they 
> are more expensive, especially on some non-x86 processors.
> 
> 2. Operations with native bit fields are (much) more readable and don't 
> contain obscure functions calls.
> 
> So, sorry, Ming, I can't commit this patch.
> 
> Vlad
> 
> Ming Zhang wrote:
> > Changed the way to represent various bits. Follow kernel style better.
> > 
> > Signed-off-by Ming Zhang <mi...@el...>
> > 
> >  scst_fileio.c |  102 ++++++++++++++++++++++++--------------
> >  1 files changed, 65 insertions(+), 37 deletions(-)
> > 
> > 
> > Ming