Re: [Scst-devel] Strange behavior in setting iSCSI portal constraints

[Sergej R. <spo...@gm...>]

Looks good to me.  Also, I'm sure that the ghost of A. de Morgan approves.

On Thu, Apr 16, 2015 at 10:01 AM, Bart Van Assche <
bar...@sa...> wrote:

> On 04/09/15 17:24, Sergej Roytman wrote:
>
>> When setting two negative portal constraints, e.g., "!152.116.40.12" and
>> "!152.116.40.13" on the same target, I observe that both IPs end up
>> being permitted rather than denied.  I tracked this down to the function
>> target_portal_allowed, in iscsi-scst/usr/target.c. The behavior in
>> 3.0.x, and also I'm told, in 3.1.0.p, is: when checking either address,
>> the globber fails to match it against the other address's constraint;
>> failure to match is taken as an endorsement; success---thing is now wide
>> open!  I assume that this is not the desired behavior.
>>
>> Please permit me to suggest a different implementation for
>> target_portal_allowed.  The original code is commented out, and the
>> header comment describes behavior.
>>
>
> Hello Sergej,
>
> That sounds like a good idea to me. It would be appreciated if you could
> verify whether the attached patch implements this behavior.
>
> Thanks,
>
> Bart.
>
>