Re: [Scst-devel] scsi_target_unblock() has changed

[Suihong L. <ho...@sy...>]

Thanks Bart.

I used:
 svn checkout svn://svn.code.sf.net/p/scst/svn/trunk scst-svn

And this is the instruction from http://scst.sourceforge.net/downloads.html

Is that the right location to check out? Please advise.

Thanks.
suihong


On 11/27/13, 2:47 AM, "Bart Van Assche" <bva...@ac...> wrote:

>On 11/26/13 23:14, Suihong Liang wrote:
>> I am trying the SCST trunk on kernel 3.11.x (which comes with ubuntu
>> 13.10). The qla2xxx device driver does not compile, because
>> function scsi_target_unblock() has a new parameter: enum
>>scsi_device_state.
>>
>> root@xu:/usr/src/linux-source-3.11.0/linux-source-3.11.0/include/scsi#
>> grep scsi_target_unblock *.*
>> scsi_device.h:extern void scsi_target_unblock(struct device *, enum
>> scsi_device_state);
>>
>> However, file qla_attr.c in current qla2xxx device driver does:
>> scsi_target_unblock(&rport->dev);
>>
>> What state should qla_attr.c use to call scsi_target_unblock()?
>>
>> Thanks!
>
>Hello Suihong,
>
>Which revision of the SCST trunk are you using ? If the version you are
>using invokes scsi_target_unblock() from the qla2x00t driver on a 3.11
>kernel then I think that means that you are using a version of the trunk
>that has been checked out before October 2012. From the SCST changelog
>(see also http://sourceforge.net/p/scst/svn/4538/):
>
>------------------------------------------------------------------------
>r4538 | vlnb | 2012-10-02 00:10:47 +0200 (Tue, 02 Oct 2012) | 3 lines
>
>Update for 3.6 kernels
>[ ... ]
>diff --git a/qla2x00t/qla_attr.c b/qla2x00t/qla_attr.c
>index 88cd662..2da1524 100644
>--- a/qla2x00t/qla_attr.c
>+++ b/qla2x00t/qla_attr.c
>@@ -1828,7 +1828,14 @@ qla2x00_terminate_rport_io(struct fc_rport *rport)
>                return;
>
>        qla2x00_abort_fcport_cmds(fcport);
>+#if (LINUX_VERSION_CODE < KERNEL_VERSION(3, 6, 0))
>        scsi_target_unblock(&rport->dev);
>+#else
>+       /*
>+        * It is not needed here, because the caller
>(fc_terminate_rport_io())
>+        * calls it.
>+        */
>+#endif
> }
>
> static int
>[ ... ]
>------------------------------------------------------------------------
>
>Bart.
>This message contains confidential information. If you are not the
>intended recipient you are hereby notified that disclosing,copying,
>distributing or taking any action in reliance on the contents of this
>information is strictly prohibited. Please notify the sender immediately
>and delete this e-mail from your system.

This message contains confidential information. If you are not the intended recipient you are hereby notified that disclosing,copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Please notify the sender immediately and delete this e-mail from your system.