Re: [Scst-devel] Emulex support

[Bart V. A. <bva...@ac...>]

On Sun, Jan 20, 2013 at 2:14 PM, Curtis <cu...@ti...> wrote:
> On 19/01/13 18:45, Bart Van Assche wrote:
>>
>> Please have a look at SAM-5 and SPC-4. The protocol identifier values
>> can be found in SPC-4 in table 477 (section 7.6, page 622). And SAM-5
>> refers to protocol-specific documentation for the initiator port
>> identifiers:
>
>
> Bart,
>         at your suggestion I downloaded SAM-5r13 and SPC-4r36 to check, and
> believe I've found a bug in the qla2x00 driver.
>
> In SPC-4, 7.6.2.2.2 indicates the FC WWPN should start at offset 16 in the
> structure, however in the code:
>
>     memcpy(&tr_id[8], sess->port_name, 8);
>
> Shouldn't that be:
>
>     memcpy(&tr_id[16], sess->port_name, 8);

Sorry but you have been looking at the wrong section. Please have a
look at section 7.6.4.2. In that section it is specified that the
N_PORT_NAME starts at offset 8, which matches the SCST implementation.

Bart.