[Scst-svn] SF.net SVN: scst:[4682] trunk/scst/src/scst_targ.c

[<vl...@us...>]

Revision: 4682
          http://scst.svn.sourceforge.net/scst/?rev=4682&view=rev
Author:   vlnb
Date:     2013-01-05 02:54:08 +0000 (Sat, 05 Jan 2013)
Log Message:
-----------
Avoid that scst_abort_cmd() triggers a false positive in Coverity

Signed-off-by: Bart Van Assche <bva...@ac...>

Modified Paths:
--------------
    trunk/scst/src/scst_targ.c

Modified: trunk/scst/src/scst_targ.c
===================================================================
--- trunk/scst/src/scst_targ.c	2013-01-04 09:43:52 UTC (rev 4681)
+++ trunk/scst/src/scst_targ.c	2013-01-05 02:54:08 UTC (rev 4682)
@@ -4799,6 +4799,13 @@
 
 	TRACE_ENTRY();
 
+	/*
+	 * Help Coverity recognize that mcmd != NULL if
+	 * call_dev_task_mgmt_fn_received == true.
+	 */
+	if (call_dev_task_mgmt_fn_received)
+		EXTRACHECKS_BUG_ON(!mcmd);
+
 	TRACE(TRACE_SCSI|TRACE_MGMT_DEBUG, "Aborting cmd %p (tag %llu, op %x)",
 		cmd, (long long unsigned int)cmd->tag, cmd->cdb[0]);
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.